zydronium/neocities
1
0
Fork 0
mirror of https://github.com/neocities/neocities.git synced 2025-04-25 09:42:36 +02:00
Code Issues Projects Releases Packages Wiki Activity

scrub question marks

Browse source
This commit is contained in:
Kyle Drake 2024-09-14 13:10:26 -05:00
parent 4fe0443a10
commit 605fa2cc74
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
models/site.rb
View file

@ -1226,6 +1226,8 @@ class Site < Sequel::Model
raise ArgumentError, 'invalid character for filename' if c < 32 raise ArgumentError, 'invalid character for filename' if c < 32
end end
# scrub question marks (I should probably just be erroring out for this)
clean_path.gsub!('?', '')
clean_path clean_path
end end

7
tests/site_file_tests.rb
View file

@ -408,6 +408,13 @@ describe 'site_files' do
_(File.exists?(@site.files_path('te[s]t.jpg'))).must_equal true _(File.exists?(@site.files_path('te[s]t.jpg'))).must_equal true
end end
it 'scrubs question marks' do
uploaded_file = Rack::Test::UploadedFile.new('./tests/files/te[s]t.jpg', 'image/jpeg')
upload 'te?st.jpg' => uploaded_file
_(last_response.body).must_match /successfully uploaded/i
_(File.exists?(@site.files_path('test.jpg'))).must_equal true
end
it 'sets site changed to false if index is empty' do it 'sets site changed to false if index is empty' do
uploaded_file = Rack::Test::UploadedFile.new('./tests/files/blankindex/index.html', 'text/html') uploaded_file = Rack::Test::UploadedFile.new('./tests/files/blankindex/index.html', 'text/html')
upload 'index.html' => uploaded_file upload 'index.html' => uploaded_file