From 1794a4bcba8f575cf0423cd7c2d1072f97576673 Mon Sep 17 00:00:00 2001
From: Kyle Drake <kyle@kyledrake.net>
Date: Sun, 15 Sep 2024 10:14:27 -0500
Subject: [PATCH] escape file path properly in dashboard, remove question mark
 scrub for now

---
 models/site.rb            | 2 --
 views/dashboard/files.erb | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/models/site.rb b/models/site.rb
index 90e420e8..0964ff2e 100644
--- a/models/site.rb
+++ b/models/site.rb
@@ -1226,8 +1226,6 @@ class Site < Sequel::Model
       raise ArgumentError, 'invalid character for filename' if c < 32
     end
 
-    # scrub question marks (I should probably just be erroring out for this)
-    clean_path.gsub!('?', '')
     clean_path
   end
 
diff --git a/views/dashboard/files.erb b/views/dashboard/files.erb
index 3a72b6d7..6d7cd3e9 100644
--- a/views/dashboard/files.erb
+++ b/views/dashboard/files.erb
@@ -98,7 +98,7 @@
             <% if file[:is_directory] %>
             <a class="link-overlay" href="?dir=<%= Rack::Utils.escape file[:path] %>" title="View <%= file[:path] %>"></a>
             <% else %>
-            <a class="link-overlay" href="<%= current_site.file_uri file[:path] %>" title="View <%= file[:path] == '/index.html' ? 'your site index' : file[:path] %>" target="_blank"></a>
+            <a class="link-overlay" href="<%= current_site.file_uri Rack::Utils.escape(file[:path]) %>" title="View <%= file[:path] == '/index.html' ? 'your site index' : file[:path] %>" target="_blank"></a>
             <% end %>
           </div>
         </div>