Michelle Rago
5b069e60d3
Mr/form updates ( #409 )
...
* Text updates
* Text updates
* Text updates
2023-02-14 14:14:50 -05:00
Seamus Johnston
ffedcac439
Update key personnel language
2023-02-06 16:03:40 -06:00
Seamus Johnston
b3784776d7
Respond to PR feedback
2023-02-03 15:39:32 -06:00
Seamus Johnston
456cab6cee
Enable domain availability checker
2023-02-03 14:22:01 -06:00
Seamus Johnston
0e3f68622f
Bypass Django internal form rendering
...
The purpose of this change is to allow direct use of Django templates
to make edits to how form fields and labels are rendered, while
retaining the validation logic provided by Django's extensive field and
widget library.
This commit additional contains:
- Remove `REQUIRED_SUFFIX`, as it is handled by the templates now
- Remove `required=True` from form fields, as this is the default
- Remove `required=False` from fields where it was added as workaround
for conditionally required questions which Django form wizard
couldn't handle
- Replace `clean_is_policy_acknowledged` with `error_messages` dict
- Remove duplicate nil entry for Federal Agency dropdown
- Update `DOMAIN_REGEX` to match whole string
- Subtle changes to `is_valid` and `get_forms` in ApplicationWizard to
reduce database calls and use form object's initial data correctly
2023-02-02 15:06:23 -06:00
Neil Martinsen-Burrell
d4ac5d92f1
Add form test and fix linting/test merge errors
2023-01-30 14:54:09 -06:00
Neil Martinsen-Burrell
b36dbf8ec1
Revert "Unrecognized tribal government more explanation"
...
This reverts commit 2cd53dc4c8
2023-01-30 11:20:59 -06:00
Neil Martinsen-Burrell
c5ada0437f
Merge branch 'main' into nmb/tribal-question
2023-01-25 11:45:49 -06:00
Neil Martinsen-Burrell
2cd53dc4c8
Unrecognized tribal government more explanation
2023-01-24 13:24:06 -06:00
Seamus Johnston
0f87d9ea9a
Respond to PR feedback
2023-01-24 10:09:36 -06:00
Seamus Johnston
f6c70f88a9
Add more code comments
...
Co-authored-by: Neil MartinsenBurrell <neil.martinsen-burrell@gsa.gov>
2023-01-24 10:03:42 -06:00
Seamus Johnston
f54276d82b
Implement dynamic questions with formsets
2023-01-24 10:03:39 -06:00
Neil Martinsen-Burrell
2c66b3728e
Tribal government question, still needs follow-up 'more information' page
2023-01-23 15:04:24 -06:00
Michelle Rago
76d2810a8a
Mr/error messages ( #369 )
...
* Make error messages match google doc.
* Update application_wizard.py
* Update application_wizard.py
* Update application_wizard.py
* Update application_wizard.py
* Update application_wizard.py
* Update application_wizard.py
* Update application_wizard.py
* Fix tests and re-format source code
* Update application_wizard.py
* Re-format code to make tests pass
Co-authored-by: Neil MartinsenBurrell <neil.martinsen-burrell@gsa.gov>
2023-01-20 15:03:45 -05:00
Neil Martinsen-Burrell
fc6bff611b
Review feedback: required questions
2023-01-12 10:28:55 -06:00
Neil Martinsen-Burrell
c0ae800d31
Fix linting errors
2023-01-10 15:09:55 -06:00
Neil Martinsen-Burrell
8b76490794
Add Type of Work section for special districts/interstate orgs
2023-01-10 14:52:24 -06:00
Neil Martinsen-Burrell
0a3c3ec9f5
Fix failing test
2023-01-10 09:08:55 -06:00
Neil Martinsen-Burrell
dc7c782050
Fix issues from merge
2023-01-09 14:03:00 -06:00
Neil Martinsen-Burrell
8d3991614e
Merge branch 'main' into nmb/field-validation
2023-01-09 13:19:24 -06:00
Neil Martinsen-Burrell
beb9a298d4
Review feedback: more required instructions
2023-01-06 13:32:26 -06:00
Seamus Johnston
607f181819
Respond to PR feedback
2023-01-06 11:45:29 -06:00
Neil Martinsen-Burrell
29d8f4b23d
Fix linting errors
2023-01-06 10:58:17 -06:00
Neil Martinsen-Burrell
f7e0975e4c
Review feedback too numerous to mention
2023-01-05 15:20:50 -06:00
Seamus Johnston
9886367dd6
Remove formtools
...
Move the ApplicationWizard from under forms/ into
views/ where each page of the application is now its
own view.
2023-01-04 08:57:28 -06:00
Neil Martinsen-Burrell
6bda7b7ead
Merge branch 'main' into nmb/field-validation
2023-01-03 12:00:52 -06:00
Neil MartinsenBurrell
d6a579ca5d
Merge pull request #336 from cisagov/nmb/skip-logic
...
Permit skipping among visited pages on the form
2023-01-03 11:36:59 -06:00
Seamus Johnston
6641fa3982
Fix linter and failing tests
2022-12-28 10:01:04 -06:00
Michelle Rago
2a9d16a555
Updated legal acknowledgement statement
2022-12-28 09:58:57 -05:00
Neil Martinsen-Burrell
427bd132e2
Test for page jumping logic and fix linting
2022-12-16 14:25:43 -06:00
Neil Martinsen-Burrell
b2905068b1
Track visited steps in session storage
2022-12-16 11:14:10 -06:00
Neil Martinsen-Burrell
3f58f03bed
Fix merge, fix tests including phone numbers
2022-12-14 15:30:58 -06:00
Neil Martinsen-Burrell
b0debba4e6
Merge branch 'main' into nmb/field-validation
2022-12-14 14:33:03 -06:00
Neil Martinsen-Burrell
c924a5fd9a
Field validation and form errors in templates
2022-12-14 13:27:14 -06:00
Seamus Johnston
e6852274ed
Address PR feedback
2022-12-13 16:34:33 -06:00
Seamus Johnston
6fe6e23368
Include real info in app review page
2022-12-12 10:07:41 -06:00
Seamus Johnston
fc353a1ff6
Update organization address fields
2022-12-09 13:27:54 -06:00
Neil Martinsen-Burrell
48f0369743
Review Feedback: labels, organization, etc.
2022-12-08 15:40:28 -06:00
Neil Martinsen-Burrell
3e878c776d
Fix merge fallout and migrations
2022-12-07 09:48:56 -06:00
Neil Martinsen-Burrell
5d56c88ba5
Merge branch 'main' into nmb/federal-combobox
2022-12-07 09:26:08 -06:00
Seamus Johnston
90557c51e8
Respond to PR feedback
2022-12-06 16:09:15 -06:00
Neil Martinsen-Burrell
ad81c13f95
Merge branch 'main' into nmb/federal-combobox
2022-12-06 14:57:06 -06:00
Neil Martinsen-Burrell
7a6dbef2b2
Fix linting
2022-12-06 14:48:08 -06:00
Seamus Johnston
07eb374d25
Save button for domain application
2022-12-05 14:38:53 -06:00
Neil Martinsen-Burrell
05d00ff55c
Select box for Top-level Federal Agency on organization contact form
2022-12-02 13:39:16 -06:00
Neil Martinsen-Burrell
c5e406c400
Add a combo box only for federal agencies
2022-11-29 15:27:56 -06:00
Seamus Johnston
758c645943
Merge branch 'main' into sspj/domain-model
2022-11-28 11:53:22 -06:00
Neil Martinsen-Burrell
d50c177eb5
Fix linting errors
2022-11-28 10:38:04 -06:00
Neil Martinsen-Burrell
98e8cc8f64
Review feedback: move policy methods to model class
2022-11-28 10:28:45 -06:00
Neil Martinsen-Burrell
45e1dcbba2
Fix linting errors
2022-11-23 13:56:59 -06:00
