zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-19 19:09:22 +02:00
Code Issues Projects Releases Packages Wiki Activity

minor updates based on comments

Browse source
This commit is contained in:
David Kennedy 2023-12-29 17:26:28 -05:00
parent af4e821d21
commit ffe34fe71e
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/registrar/models/domain.py
View file

@ -976,7 +976,7 @@ class Domain(TimeStampedModel, DomainHelper):
security_contact_registry_id = TextField( security_contact_registry_id = TextField(
null=True, null=True,
help_text=("Duplication of registry's security contact id for when registry unavailable"), help_text=("Duplication of registry's security contact id for when the registry is unavailable"),
editable=False, editable=False,
) )
@ -1124,7 +1124,7 @@ class Domain(TimeStampedModel, DomainHelper):
# if contact type is security, attempt to retrieve registry id # if contact type is security, attempt to retrieve registry id
# for the security contact from domain.security_contact_registry_id # for the security contact from domain.security_contact_registry_id
if contact_type_choice == PublicContact.ContactTypeChoices.SECURITY and self.security_contact_registry_id: if contact_type_choice == PublicContact.ContactTypeChoices.SECURITY and self.security_contact_registry_id:
logger.info(self.security_contact_registry_id) logger.info(f"Could not access registry, using fallback value of {self.security_contact_registry_id}")
contacts = {PublicContact.ContactTypeChoices.SECURITY: self.security_contact_registry_id} contacts = {PublicContact.ContactTypeChoices.SECURITY: self.security_contact_registry_id}
else: else:
logger.error(f"Could not find {contact_type_choice}: {error}") logger.error(f"Could not find {contact_type_choice}: {error}")
@ -1747,8 +1747,9 @@ class Domain(TimeStampedModel, DomainHelper):
if fetch_contacts: if fetch_contacts:
cleaned_contacts = cleaned["contacts"] cleaned_contacts = cleaned["contacts"]
security_contact_registry_id = "" security_contact_registry_id = ""
if cleaned_contacts[PublicContact.ContactTypeChoices.SECURITY]: security_contact = cleaned_contacts[PublicContact.ContactTypeChoices.SECURITY]
security_contact_registry_id = cleaned_contacts[PublicContact.ContactTypeChoices.SECURITY] if security_contact:
security_contact_registry_id = security_contact
self.security_contact_registry_id = security_contact_registry_id self.security_contact_registry_id = security_contact_registry_id
self.save() self.save()