zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-19 10:59:21 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1459 from cisagov/es/1324-availability-case-sensitivity

Browse source 
#1324 Fix availability case sensitivity bug
This commit is contained in:
Erin Song 2023-12-11 14:58:46 -08:00 • committed by GitHub
commit fce0eb0370
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/api/tests/test_available.py
View file

@ -69,8 +69,8 @@ class AvailableViewTest(MockEppLib):
self.assertTrue(check_domain_available("igorville.gov")) self.assertTrue(check_domain_available("igorville.gov"))
# input is lowercased so GSA.GOV should also not be available # input is lowercased so GSA.GOV should also not be available
self.assertFalse(check_domain_available("GSA.gov")) self.assertFalse(check_domain_available("GSA.gov"))
# input is lowercased so IGORVILLE.GOV should also not be available # input is lowercased so IGORVILLE.GOV should also be available
self.assertFalse(check_domain_available("IGORVILLE.gov")) self.assertTrue(check_domain_available("IGORVILLE.gov"))
def test_domain_available_dotgov(self): def test_domain_available_dotgov(self):
"""Domain searches work without trailing .gov""" """Domain searches work without trailing .gov"""

3
src/registrar/models/domain.py
View file

@ -174,7 +174,8 @@ class Domain(TimeStampedModel, DomainHelper):
"""Check if a domain is available.""" """Check if a domain is available."""
if not cls.string_could_be_domain(domain): if not cls.string_could_be_domain(domain):
raise ValueError("Not a valid domain: %s" % str(domain)) raise ValueError("Not a valid domain: %s" % str(domain))
req = commands.CheckDomain([domain]) domain_name = domain.lower()
req = commands.CheckDomain([domain_name])
return registry.send(req, cleaned=True).res_data[0].avail return registry.send(req, cleaned=True).res_data[0].avail
@classmethod @classmethod

4
src/registrar/tests/common.py
View file

@ -829,10 +829,8 @@ class MockEppLib(TestCase):
def mockCheckDomainCommand(self, _request, cleaned): def mockCheckDomainCommand(self, _request, cleaned):
if "gsa.gov" in getattr(_request, "names", None): if "gsa.gov" in getattr(_request, "names", None):
return self._mockDomainName("gsa.gov", False) return self._mockDomainName("gsa.gov", False)
elif "GSA.gov" in getattr(_request, "names", None):
return self._mockDomainName("GSA.gov", False)
elif "igorville.gov" in getattr(_request, "names", None): elif "igorville.gov" in getattr(_request, "names", None):
return self._mockDomainName("igorvilleremixed.gov", True) return self._mockDomainName("igorville.gov", True)
elif "top-level-agency.gov" in getattr(_request, "names", None): elif "top-level-agency.gov" in getattr(_request, "names", None):
return self._mockDomainName("top-level-agency.gov", True) return self._mockDomainName("top-level-agency.gov", True)
elif "city.gov" in getattr(_request, "names", None): elif "city.gov" in getattr(_request, "names", None):