Review feedback too numerous to mention

This commit is contained in:
Neil Martinsen-Burrell 2023-01-05 15:20:50 -06:00
parent 56606f32e0
commit f7e0975e4c
No known key found for this signature in database
GPG key ID: 6A3C818CC10D0184
17 changed files with 196 additions and 57 deletions

View file

@ -6,6 +6,7 @@ from registrar.forms.application_wizard import (
CurrentSitesForm,
DotGovDomainForm,
AuthorizingOfficialForm,
OrganizationContactForm,
YourContactForm,
OtherContactsForm,
SecurityEmailForm,
@ -14,6 +15,17 @@ from registrar.forms.application_wizard import (
class TestFormValidation(TestCase):
def test_org_contact_zip_invalid(self):
form = OrganizationContactForm (data={"zipcode": "nah"})
self.assertEqual(
form.errors["zipcode"], ["Please enter a ZIP code in the form 12345 or 12345-6789"]
)
def test_org_contact_zip_valid(self):
for zipcode in ["12345", "12345-6789"]:
form = OrganizationContactForm (data={"zipcode": zipcode})
self.assertNotIn("zipcode", form.errors)
def test_current_site_invalid(self):
form = CurrentSitesForm(data={"current_site": "nah"})
self.assertEqual(
@ -24,6 +36,12 @@ class TestFormValidation(TestCase):
form = CurrentSitesForm(data={"current_site": "hyphens-rule.gov.uk"})
self.assertEqual(len(form.errors), 0)
def test_current_site_scheme_valid(self):
form = CurrentSitesForm(data={"current_site": "http://hyphens-rule.gov.uk"})
self.assertEqual(len(form.errors), 0)
form = CurrentSitesForm(data={"current_site": "https://hyphens-rule.gov.uk"})
self.assertEqual(len(form.errors), 0)
def test_requested_domain_valid(self):
"""Just a valid domain name with no .gov at the end."""
form = DotGovDomainForm(data={"requested_domain": "top-level-agency"})