zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-17 18:09:25 +02:00
Code Issues Projects Releases Packages Wiki Activity

linter fixes

Browse source
This commit is contained in:
Matthew Spence 2024-08-26 11:54:08 -05:00
parent 497837b098
commit f7b2e38bba
No known key found for this signature in database
3 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/registrar/management/commands/populate_domain_request_dates.py
View file

@ -3,7 +3,6 @@ from django.core.management import BaseCommand
from registrar.management.commands.utility.terminal_helper import PopulateScriptTemplate, TerminalColors
from registrar.models import DomainRequest
from auditlog.models import LogEntry
from django.core.exceptions import ObjectDoesNotExist
logger = logging.getLogger(__name__)
@ -12,7 +11,8 @@ class Command(BaseCommand, PopulateScriptTemplate):
help = "Loops through each domain request object and populates the last_status_update and first_submitted_date"
def handle(self, **kwargs):
"""Loops through each DomainRequest object and populates its last_status_update and first_submitted_date values"""
"""Loops through each DomainRequest object and populates
its last_status_update and first_submitted_date values"""
self.mass_update_records(DomainRequest, None, ["last_status_update", "first_submitted_date"])
def update_record(self, record: DomainRequest):
@ -34,7 +34,10 @@ class Command(BaseCommand, PopulateScriptTemplate):
break
logger.info(
f"{TerminalColors.OKCYAN}Updating {record} => first submitted date: " f"{record.first_submitted_date}, last status update:" f"{record.last_status_update}{TerminalColors.ENDC}"
f"""{TerminalColors.OKCYAN}Updating {record} =>
first submitted date: {record.first_submitted_date},
last status update: {record.last_status_update}{TerminalColors.ENDC}
"""
)
def should_skip_record(self, record) -> bool:

6
src/registrar/tests/test_views_requests_json.py
View file

@ -287,7 +287,8 @@ class GetRequestsJsonTest(TestWithUser, WebTest):
def test_sorting(self):
"""test that sorting works properly on the result set"""
response = self.app.get(reverse("get_domain_requests_json"), {"sort_by": "last_submitted_date", "order": "desc"})
response = self.app.get(reverse("get_domain_requests_json"),
{"sort_by": "last_submitted_date", "order": "desc"})
self.assertEqual(response.status_code, 200)
data = response.json
@ -306,7 +307,8 @@ class GetRequestsJsonTest(TestWithUser, WebTest):
def test_filter_approved_excluded(self):
"""test that approved requests are excluded from result set."""
# sort in reverse chronological order of submission date, since most recent request is approved
response = self.app.get(reverse("get_domain_requests_json"), {"sort_by": "last_submitted_date", "order": "desc"})
response = self.app.get(reverse("get_domain_requests_json"),
{"sort_by": "last_submitted_date", "order": "desc"})
self.assertEqual(response.status_code, 200)
data = response.json