zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-13 21:19:42 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1803 from cisagov/za/1795-staging-data-domaininformation-overwritten

Browse source 
(Hot fix) Ticket #1795: DomainInformation being overwritten in some circumstances
This commit is contained in:
zandercymatics 2024-02-21 08:16:01 -07:00 • committed by GitHub
commit f72e81af5c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/registrar/models/domain_information.py
View file

@ -255,6 +255,14 @@ class DomainInformation(TimeStampedModel):
else: else:
da_many_to_many_dict[field] = getattr(domain_application, field).all() da_many_to_many_dict[field] = getattr(domain_application, field).all()
# This will not happen in normal code flow, but having some redundancy doesn't hurt.
# da_dict should not have "id" under any circumstances.
# If it does have it, then this indicates that common_fields is overzealous in the data
# that it is returning. Try looking in DomainHelper.get_common_fields.
if "id" in da_dict:
logger.warning("create_from_da() -> Found attribute 'id' when trying to create")
da_dict.pop("id", None)
# Create a placeholder DomainInformation object # Create a placeholder DomainInformation object
domain_info = DomainInformation(**da_dict) domain_info = DomainInformation(**da_dict)

4
src/registrar/models/utility/domain_helper.py
View file

@ -180,8 +180,8 @@ class DomainHelper:
""" """
# Get a list of the existing fields on model_1 and model_2 # Get a list of the existing fields on model_1 and model_2
model_1_fields = set(field.name for field in model_1._meta.get_fields() if field != "id") model_1_fields = set(field.name for field in model_1._meta.get_fields() if field.name != "id")
model_2_fields = set(field.name for field in model_2._meta.get_fields() if field != "id") model_2_fields = set(field.name for field in model_2._meta.get_fields() if field.name != "id")
# Get the fields that exist on both DomainApplication and DomainInformation # Get the fields that exist on both DomainApplication and DomainInformation
common_fields = model_1_fields & model_2_fields common_fields = model_1_fields & model_2_fields