Review feedback: name changes

This commit is contained in:
Neil Martinsen-Burrell 2023-04-03 15:04:53 -05:00
parent 58977f14f2
commit f66df2c931
No known key found for this signature in database
GPG key ID: 6A3C818CC10D0184
3 changed files with 5 additions and 5 deletions

View file

@ -10,7 +10,7 @@ from .user_domain_role import UserDomainRole
class DomainInvitation(TimeStampedModel): class DomainInvitation(TimeStampedModel):
SENT = "sent" INVITED = "invited"
RETRIEVED = "retrieved" RETRIEVED = "retrieved"
email = models.EmailField( email = models.EmailField(
@ -27,17 +27,17 @@ class DomainInvitation(TimeStampedModel):
status = FSMField( status = FSMField(
choices=[ choices=[
(SENT, SENT), (INVITED, INVITED),
(RETRIEVED, RETRIEVED), (RETRIEVED, RETRIEVED),
], ],
default=SENT, default=INVITED,
protected=True, # can't alter state except through transition methods! protected=True, # can't alter state except through transition methods!
) )
def __str__(self): def __str__(self):
return f"Invitation for {self.email} on {self.domain} is {self.status}" return f"Invitation for {self.email} on {self.domain} is {self.status}"
@transition(field="status", source=SENT, target=RETRIEVED) @transition(field="status", source=INVITED, target=RETRIEVED)
def retrieve(self): def retrieve(self):
"""When an invitation is retrieved, create the corresponding permission.""" """When an invitation is retrieved, create the corresponding permission."""

View file

@ -41,7 +41,7 @@ class User(AbstractUser):
invitations that match their email address. invitations that match their email address.
""" """
for invitation in DomainInvitation.objects.filter( for invitation in DomainInvitation.objects.filter(
email=self.email, status=DomainInvitation.SENT email=self.email, status=DomainInvitation.INVITED
): ):
invitation.retrieve() invitation.retrieve()
invitation.save() invitation.save()