zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-02 17:23:32 +02:00
Code Issues Projects Releases Packages Wiki Activity

Create code review guide

Browse source
This commit is contained in:
Erin Song 2024-10-03 10:33:45 -07:00
parent f9e60ac237
commit f10b4d8285
No known key found for this signature in database
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.github/pull_request_template.md vendored
View file

@ -1,6 +1,6 @@
## Ticket
Resolves #00
Resolves #001
<!--Reminder, when a code change is made that is user facing, beyond content updates, then the following are required:
- a developer approves the PR
- a designer approves the PR or checks off all relevant items in this checklist.

6
docs/dev-practices/code_review.md Normal file
View file

@ -0,0 +1,6 @@
# Code Review
After creating a pull request, pull request submitters should:
- Add at least 2 developers as PR reviewers (only 1 will need to approve)
- Message on Slack or in standup to notify the team that a PR is ready for review
- If any model was updated to modify/add/delete columns, run makemigrations and commit the associated migrations file.