zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-06-10 06:24:45 +02:00
Code Issues Projects Releases Packages Wiki Activity

Review feedback: error tolerance, logging, etc.

Browse source
This commit is contained in:
Neil Martinsen-Burrell 2023-02-14 13:31:00 -06:00
parent a314b905d3
commit f0ecae08c5
No known key found for this signature in database
GPG key ID: 6A3C818CC10D0184
3 changed files with 43 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/registrar/models/domain_application.py
View file

@ -8,7 +8,7 @@ from django.db import models
from django_fsm import FSMField, transition # type: ignore
from .utility.time_stamped_model import TimeStampedModel
from ..utility.email import send_templated_email
from ..utility.email import send_templated_email, EmailSendingError
logger = logging.getLogger(__name__)
@ -478,11 +478,14 @@ class DomainApplication(TimeStampedModel):
if self.submitter is None or self.submitter.email is None:
logger.warn("Cannot send confirmation email, no submitter email address.")
return
send_templated_email(
"emails/submission_confirmation.txt",
self.submitter.email,
context={"id": self.id, "domain_name": self.requested_domain.name},
)
try:
send_templated_email(
"emails/submission_confirmation.txt",
self.submitter.email,
context={"id": self.id, "domain_name": self.requested_domain.name},
)
except EmailSendingError:
logger.warning("Failed to send confirmation email", exc_info=True)
@transition(field="status", source=STARTED, target=SUBMITTED)
def submit(self):