zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-06-11 06:54:48 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove extraneous TODOs except for 1

Browse source
This commit is contained in:
Rebecca Hsieh 2024-03-13 08:48:25 -07:00
parent 7e6cf54781
commit f0b510f09d
No known key found for this signature in database
2 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/registrar/management/commands/email_current_metadata_report.py
View file

@ -75,8 +75,6 @@ class Command(BaseCommand):
# Set context for the subject # Set context for the subject
current_date_str = datetime.now().strftime("%Y-%m-%d") current_date_str = datetime.now().strftime("%Y-%m-%d")
# TODO: Update secret in getgov-credentials via cloud.gov and my own .env when merging
# Encrypt the metadata # Encrypt the metadata
encrypted_metadata_in_bytes = self._encrypt_metadata( encrypted_metadata_in_bytes = self._encrypt_metadata(
s3_client.get_file(file_name), encrypted_metadata_output, str.encode(settings.SECRET_ENCRYPT_METADATA) s3_client.get_file(file_name), encrypted_metadata_output, str.encode(settings.SECRET_ENCRYPT_METADATA)
@ -86,7 +84,7 @@ class Command(BaseCommand):
send_templated_email( send_templated_email(
template_name="emails/metadata_body.txt", template_name="emails/metadata_body.txt",
subject_template_name="emails/metadata_subject.txt", subject_template_name="emails/metadata_subject.txt",
# to_address=settings.DEFAULT_FROM_EMAIL, # TODO: Uncomment this when ready to merge # to_address=settings.DEFAULT_FROM_EMAIL,
to_address="rebecca.hsieh@truss.works <rebecca.hsieh@truss.works>", to_address="rebecca.hsieh@truss.works <rebecca.hsieh@truss.works>",
context={"current_date_str": current_date_str}, context={"current_date_str": current_date_str},
attachment_file=encrypted_metadata_in_bytes, attachment_file=encrypted_metadata_in_bytes,

5
src/registrar/utility/email.py
View file

@ -75,12 +75,9 @@ def send_templated_email(
aws_secret_access_key=settings.AWS_SECRET_ACCESS_KEY, aws_secret_access_key=settings.AWS_SECRET_ACCESS_KEY,
config=settings.BOTO_CONFIG, config=settings.BOTO_CONFIG,
) )
response = send_email_with_attachment( send_email_with_attachment(
settings.DEFAULT_FROM_EMAIL, to_address, subject, email_body, attachment_file, ses_client settings.DEFAULT_FROM_EMAIL, to_address, subject, email_body, attachment_file, ses_client
) )
# TODO: Remove this print statement when ready to merge,
# leaving rn for getting error codes in case
print("Response from send_email_with_attachment_is:", response)
except Exception as exc: except Exception as exc:
raise EmailSendingError("Could not send SES email.") from exc raise EmailSendingError("Could not send SES email.") from exc