zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-31 06:56:33 +02:00
Code Issues Projects Releases Packages Wiki Activity

Change action needed reason from 'Already has domains' to 'Already has a domain'

Browse source
This commit is contained in:
lizpearl 2024-11-27 14:56:16 -06:00
parent d11bffed01
commit efc4e71625
No known key found for this signature in database
GPG key ID: 29F55F4C8D404E14
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/registrar/models/domain_request.py
View file

@ -280,7 +280,7 @@ class DomainRequest(TimeStampedModel):
ELIGIBILITY_UNCLEAR = ("eligibility_unclear", "Unclear organization eligibility") ELIGIBILITY_UNCLEAR = ("eligibility_unclear", "Unclear organization eligibility")
QUESTIONABLE_SENIOR_OFFICIAL = ("questionable_senior_official", "Questionable senior official") QUESTIONABLE_SENIOR_OFFICIAL = ("questionable_senior_official", "Questionable senior official")
ALREADY_HAS_DOMAINS = ("already_has_domains", "Already has domains") ALREADY_HAS_A_DOMAIN = ("already_has_a_domain", "Already has a domain")
BAD_NAME = ("bad_name", "Doesn’t meet naming requirements") BAD_NAME = ("bad_name", "Doesn’t meet naming requirements")
OTHER = ("other", "Other (no auto-email sent)") OTHER = ("other", "Other (no auto-email sent)")

0
src/registrar/templates/emails/action_needed_reasons/already_has_domains.txt → src/registrar/templates/emails/action_needed_reasons/already_has_a_domain.txt
View file

12
src/registrar/tests/test_admin_request.py
View file

@ -203,7 +203,7 @@ class TestDomainRequestAdmin(MockEppLib):
domain_request.save() domain_request.save()
domain_request.action_needed() domain_request.action_needed()
domain_request.action_needed_reason = DomainRequest.ActionNeededReasons.ALREADY_HAS_DOMAINS domain_request.action_needed_reason = DomainRequest.ActionNeededReasons.ALREADY_HAS_A_DOMAIN
domain_request.save() domain_request.save()
# Let's just change the action needed reason # Let's just change the action needed reason
@ -230,7 +230,7 @@ class TestDomainRequestAdmin(MockEppLib):
"In review", "In review",
"Rejected - Purpose requirements not met", "Rejected - Purpose requirements not met",
"Action needed - Unclear organization eligibility", "Action needed - Unclear organization eligibility",
"Action needed - Already has domains", "Action needed - Already has a domain",
"In review", "In review",
"Submitted", "Submitted",
"Started", "Started",
@ -241,7 +241,7 @@ class TestDomainRequestAdmin(MockEppLib):
assert_status_count(normalized_content, "Started", 1) assert_status_count(normalized_content, "Started", 1)
assert_status_count(normalized_content, "Submitted", 1) assert_status_count(normalized_content, "Submitted", 1)
assert_status_count(normalized_content, "In review", 2) assert_status_count(normalized_content, "In review", 2)
assert_status_count(normalized_content, "Action needed - Already has domains", 1) assert_status_count(normalized_content, "Action needed - Already has a domain", 1)
assert_status_count(normalized_content, "Action needed - Unclear organization eligibility", 1) assert_status_count(normalized_content, "Action needed - Unclear organization eligibility", 1)
assert_status_count(normalized_content, "Rejected - Purpose requirements not met", 1) assert_status_count(normalized_content, "Rejected - Purpose requirements not met", 1)
@ -685,9 +685,9 @@ class TestDomainRequestAdmin(MockEppLib):
# Create a sample domain request # Create a sample domain request
domain_request = completed_domain_request(status=in_review, user=_creator) domain_request = completed_domain_request(status=in_review, user=_creator)
# Test the email sent out for already_has_domains # Test the email sent out for already_has_a_domain
already_has_domains = DomainRequest.ActionNeededReasons.ALREADY_HAS_DOMAINS already_has_a_domain = DomainRequest.ActionNeededReasons.ALREADY_HAS_A_DOMAIN
self.transition_state_and_send_email(domain_request, action_needed, action_needed_reason=already_has_domains) self.transition_state_and_send_email(domain_request, action_needed, action_needed_reason=already_has_a_domain)
self.assert_email_is_accurate("ORGANIZATION ALREADY HAS A .GOV DOMAIN", 0, EMAIL, bcc_email_address=BCC_EMAIL) self.assert_email_is_accurate("ORGANIZATION ALREADY HAS A .GOV DOMAIN", 0, EMAIL, bcc_email_address=BCC_EMAIL)
self.assertEqual(len(self.mock_client.EMAILS_SENT), 1) self.assertEqual(len(self.mock_client.EMAILS_SENT), 1)