From ed3d8ccf726cc1c146fdc588c629e286776d75dd Mon Sep 17 00:00:00 2001 From: Alysia Broddrick Date: Mon, 2 Oct 2023 09:21:03 -0700 Subject: [PATCH] fixed failing tests --- src/registrar/tests/common.py | 8 +++----- src/registrar/tests/test_models_domain.py | 1 + 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/registrar/tests/common.py b/src/registrar/tests/common.py index 98e9287ed..1cb0f7893 100644 --- a/src/registrar/tests/common.py +++ b/src/registrar/tests/common.py @@ -638,8 +638,7 @@ class MockEppLib(TestCase): # TODO-848: Fix naming extendedValues = False - # TODO-848: Rename later - was getting complex err - def _getattrshelper(self, _request): + def _getattrInfoDomain(self, _request): if getattr(_request, "name", None) == "security.gov": return MagicMock(res_data=[self.infoDomainNoContact]) elif getattr(_request, "name", None) == "my-nameserver.gov": @@ -653,7 +652,7 @@ class MockEppLib(TestCase): return MagicMock(res_data=[self.infoDomainHasIP]) # elif getattr(_request, "name", None) == "failednameserver.gov": # return MagicMock(res_data=[self.infoDomainUpdateFail]) - # return MagicMock(res_data=[self.mockDataInfoDomain]) + return MagicMock(res_data=[self.mockDataInfoDomain]) def mockSend(self, _request, cleaned): """Mocks the registry.send function used inside of domain.py @@ -661,8 +660,7 @@ class MockEppLib(TestCase): returns objects that simulate what would be in a epp response but only relevant pieces for tests""" if isinstance(_request, commands.InfoDomain): - # TODO-848: Fix name here - return self._getattrshelper(_request) + return self._getattrInfoDomain(_request) elif isinstance(_request, commands.InfoContact): return MagicMock(res_data=[self.mockDataInfoContact]) elif ( diff --git a/src/registrar/tests/test_models_domain.py b/src/registrar/tests/test_models_domain.py index 49264cd67..7a7056a26 100644 --- a/src/registrar/tests/test_models_domain.py +++ b/src/registrar/tests/test_models_domain.py @@ -90,6 +90,7 @@ class TestDomainCache(MockEppLib): } expectedHostsDict = { "name": self.mockDataInfoDomain.hosts[0], + "addrs":self.mockDataInfoHosts.addrs, "cr_date": self.mockDataInfoHosts.cr_date, }