zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-24 03:30:50 +02:00
Code Issues Projects Releases Packages Wiki Activity

Incorporate feedback

Browse source
This commit is contained in:
Erin Song 2024-10-07 11:30:31 -07:00
parent c20f7e6679
commit ec74cfb24d
No known key found for this signature in database
2 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/dev-practices/code_review.md
View file

@ -7,7 +7,6 @@ After creating a pull request, pull request submitters should:
- Add at least 2 developers as PR reviewers (only 1 will need to approve).
- Message on Slack or in standup to notify the team that a PR is ready for review.
- If any model was updated to modify/add/delete columns, run makemigrations and commit the associated migrations file.
- If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
## Pull request approvals
Code changes on user-facing features (excluding content updates) require approval from at least one developer and one designer.