zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-05 17:28:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

small refactor

Browse source
This commit is contained in:
David Kennedy 2024-07-18 13:48:27 -04:00
parent d51649dfba
commit e9ba08f20a
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
6 changed files with 61 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

37
src/registrar/views/utility/mixins.py
View file

@ -2,7 +2,6 @@
from django.contrib.auth.mixins import PermissionRequiredMixin
from registrar.context_processors import portfolio_permissions
from registrar.models import (
Domain,
DomainRequest,
@ -414,40 +413,34 @@ class PortfolioBasePermission(PermissionsLoginMixin):
if not self.request.user.is_authenticated:
return False
permission_dict = portfolio_permissions(self.request)
has_permission = permission_dict["has_base_portfolio_permission"]
if not has_permission:
return False
return True
return self.request.user.has_base_portfolio_permission()
class PortfolioDomainsPermission(PortfolioBasePermission):
""" """
"""Permission mixin that allows access to portfolio domain pages if user
has access, otherwise 403"""
def has_permission(self):
""" """
"""Check if this user has access to domains for this portfolio.
permission_dict = portfolio_permissions(self.request)
has_permission = permission_dict["has_domains_portfolio_permission"]
The user is in self.request.user and the portfolio can be looked
up from the portfolio's primary key in self.kwargs["pk"]"""
if not has_permission:
if not self.request.user.is_authenticated:
return False
return True
return self.request.user.has_domains_portfolio_permission()
class PortfolioDomainRequestsPermission(PortfolioBasePermission):
""" """
"""Permission mixin that allows access to portfolio domain request pages if user
has access, otherwise 403"""
def has_permission(self):
""" """
"""Check if this user has access to domain requests for this portfolio.
permission_dict = portfolio_permissions(self.request)
has_permission = permission_dict["has_domain_requests_portfolio_permission"]
The user is in self.request.user and the portfolio can be looked
up from the portfolio's primary key in self.kwargs["pk"]"""
if not has_permission:
if not self.request.user.is_authenticated:
return False
return True
return self.request.user.has_domain_requests_portfolio_permission()