zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-20 09:46:06 +02:00
Code Issues Projects Releases Packages Wiki Activity

Lint + fix tests

Browse source
This commit is contained in:
zandercymatics 2024-10-04 09:58:27 -06:00
parent 4aa91ccc9c
commit e9413a53bd
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
1 changed files with 7 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/registrar/tests/test_views_request.py
View file

@ -2771,17 +2771,18 @@ class DomainRequestTests(TestWithUser, WebTest):
portfolio_perm, _ = UserPortfolioPermission.objects.get_or_create( portfolio_perm, _ = UserPortfolioPermission.objects.get_or_create(
user=self.user, portfolio=portfolio, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN] user=self.user, portfolio=portfolio, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN]
) )
# This user should be allowed to create new domain requests # This user should be allowed to create new domain requests
intro_page = self.app.get(reverse("domain-request:")) intro_page = self.app.get(reverse("domain-request:"))
self.assertEqual(intro_page.status_code, 200) self.assertEqual(intro_page.status_code, 200)
# This user should also be allowed to edit existing ones # This user should also be allowed to edit existing ones
domain_request = completed_domain_request(user=self.user) domain_request = completed_domain_request(user=self.user)
edit_page = self.app.get(reverse("edit-domain-request", kwargs={"id": domain_request.pk})) edit_page = self.app.get(reverse("edit-domain-request", kwargs={"id": domain_request.pk})).follow()
self.assertEqual(edit_page.status_code, 200) self.assertEqual(edit_page.status_code, 200)
# Cleanup # Cleanup
DomainRequest.objects.all().delete()
portfolio_perm.delete() portfolio_perm.delete()
portfolio.delete() portfolio.delete()
@ -2797,7 +2798,7 @@ class DomainRequestTests(TestWithUser, WebTest):
"""Tests that a user can edit a domain request they created""" """Tests that a user can edit a domain request they created"""
domain_request = completed_domain_request(user=self.user) domain_request = completed_domain_request(user=self.user)
edit_page = self.app.get(reverse("edit-domain-request", kwargs={"id": domain_request.pk})) edit_page = self.app.get(reverse("edit-domain-request", kwargs={"id": domain_request.pk})).follow()
self.assertEqual(edit_page.status_code, 200) self.assertEqual(edit_page.status_code, 200)
@ -2986,10 +2987,7 @@ class TestDomainRequestWizard(TestWithUser, WebTest):
def test_unlocked_steps_full_domain_request(self): def test_unlocked_steps_full_domain_request(self):
"""Test when all fields in the domain request are filled.""" """Test when all fields in the domain request are filled."""
domain_request = completed_domain_request( domain_request = completed_domain_request(status=DomainRequest.DomainRequestStatus.STARTED, user=self.user)
status=DomainRequest.DomainRequestStatus.STARTED,
user=self.user
)
domain_request.anything_else = False domain_request.anything_else = False
domain_request.has_anything_else_text = False domain_request.has_anything_else_text = False
domain_request.save() domain_request.save()
@ -3099,7 +3097,7 @@ class TestDomainRequestWizard(TestWithUser, WebTest):
- The user lands on the "Requesting entity" page - The user lands on the "Requesting entity" page
- The user does not see the Domain and Domain requests buttons - The user does not see the Domain and Domain requests buttons
""" """
# This should unlock 4 steps by default. # This should unlock 4 steps by default.
# Purpose, .gov domain, current websites, and requirements for operating # Purpose, .gov domain, current websites, and requirements for operating
domain_request = completed_domain_request( domain_request = completed_domain_request(
@ -3167,7 +3165,7 @@ class TestDomainRequestWizard(TestWithUser, WebTest):
self.assertNotContains(detail_page, "Domain requests") self.assertNotContains(detail_page, "Domain requests")
else: else:
self.fail(f"Expected a redirect, but got a different response: {response}") self.fail(f"Expected a redirect, but got a different response: {response}")
# Data cleanup # Data cleanup
user_portfolio_permission.delete() user_portfolio_permission.delete()
portfolio.delete() portfolio.delete()