removed the remaining profile feature"

src/registrar/tests/test_admin_request.py

@@ -957,7 +957,6 @@ class TestDomainRequestAdmin(MockEppLib):
         self.transition_state_and_send_email(domain_request, DomainRequest.DomainRequestStatus.SUBMITTED)
         self.assertEqual(len(self.mock_client.EMAILS_SENT), 3)
 
-    @override_flag("profile_feature", True)
     @less_console_noise_decorator
     def test_save_model_sends_approved_email(self):
         """When transitioning to approved on a domain request,

src/registrar/tests/test_models.py

@@ -256,7 +256,6 @@ class TestDomainRequest(TestCase):
 
         email_allowed.delete()
 
-    @override_flag("profile_feature", active=True)
     @less_console_noise_decorator
     def test_submit_from_started_sends_email_to_creator(self):
         """Tests if, when the profile feature flag is on, we send an email to the creator"""

src/registrar/tests/test_views.py

@@ -552,7 +552,6 @@ class FinishUserProfileTests(TestWithUser, WebTest):
         return page.follow() if follow else page
 
     @less_console_noise_decorator
-    @override_flag("profile_feature", active=True)
     def test_full_name_initial_value(self):
         """Test that full_name initial value is empty when first_name or last_name is empty.
         This will later be displayed as "unknown" using javascript."""
@@ -606,8 +605,8 @@ class FinishUserProfileTests(TestWithUser, WebTest):
         incomplete_regular_user.delete()
 
     @less_console_noise_decorator
-    def test_new_user_with_profile_feature_on(self):
+    def test_new_user(self):
-        """Tests that a new user is redirected to the profile setup page when profile_feature is on"""
+        """Tests that a new user is redirected to the profile setup page"""
         username_regular_incomplete = "test_regular_user_incomplete"
         first_name_2 = "Incomplete"
         email_2 = "unicorn@igorville.com"
@@ -620,12 +619,10 @@ class FinishUserProfileTests(TestWithUser, WebTest):
         )
 
         self.app.set_user(incomplete_regular_user.username)
-        with override_flag("profile_feature", active=True):
         # This will redirect the user to the setup page.
         # Follow implicity checks if our redirect is working.
         finish_setup_page = self.app.get(reverse("home")).follow()
         self._set_session_cookie()
-
         # Assert that we're on the right page
         self.assertContains(finish_setup_page, "Finish setting up your profile")
 
@@ -669,7 +666,6 @@ class FinishUserProfileTests(TestWithUser, WebTest):
             verification_type=User.VerificationTypeChoices.REGULAR,
         )
         self.app.set_user(incomplete_regular_user.username)
-        with override_flag("profile_feature", active=True):
         # This will redirect the user to the setup page.
         # Follow implicity checks if our redirect is working.
         finish_setup_page = self.app.get(reverse("home")).follow()
@@ -707,8 +703,8 @@ class FinishUserProfileTests(TestWithUser, WebTest):
         incomplete_regular_user.delete()
 
     @less_console_noise_decorator
-    def test_new_user_goes_to_domain_request_with_profile_feature_on(self):
+    def test_new_user_goes_to_domain_request(self):
-        """Tests that a new user is redirected to the domain request page when profile_feature is on"""
+        """Tests that a new user is redirected to the domain request page"""
         username_regular_incomplete = "test_regular_user_incomplete"
         first_name_2 = "Incomplete"
         email_2 = "unicorn@igorville.com"
@@ -720,7 +716,7 @@ class FinishUserProfileTests(TestWithUser, WebTest):
             verification_type=User.VerificationTypeChoices.REGULAR,
         )
         self.app.set_user(incomplete_regular_user.username)
-        with override_flag("profile_feature", active=True):
+        with override_flag("", active=True):
             # This will redirect the user to the setup page
             finish_setup_page = self.app.get(reverse("domain-request:")).follow()
             self._set_session_cookie()
@@ -803,8 +799,8 @@ class FinishUserProfileForOtherUsersTests(TestWithUser, WebTest):
         return page.follow() if follow else page
 
     @less_console_noise_decorator
-    def test_new_user_with_profile_feature_on(self):
+    def test_new_user(self):
-        """Tests that a new user is redirected to the profile setup page when profile_feature is on,
+        """Tests that a new user is redirected to the profile setup page,
         and testing that the confirmation modal is present"""
         username_other_incomplete = "test_other_user_incomplete"
         first_name_2 = "Incomplete"
@@ -818,7 +814,6 @@ class FinishUserProfileForOtherUsersTests(TestWithUser, WebTest):
             verification_type=User.VerificationTypeChoices.VERIFIED_BY_STAFF,
         )
         self.app.set_user(incomplete_other_user.username)
-        with override_flag("profile_feature", active=True):
         # This will redirect the user to the user profile page.
         # Follow implicity checks if our redirect is working.
         user_profile_page = self.app.get(reverse("home")).follow()
@@ -868,9 +863,7 @@ class FinishUserProfileForOtherUsersTests(TestWithUser, WebTest):
         # NOTE: "anage" is not a typo.  It is to accomodate the fact that the "m" is uppercase in one
         # instance and lowercase in the other.
         self.assertContains(save_page, "anage your domains", count=2)
-            self.assertNotContains(
+        self.assertNotContains(save_page, "Before you can manage your domains, we need you to add contact information")
-                save_page, "Before you can manage your domains, we need you to add contact information"
-            )
         # Assert that modal does not appear on subsequent submits
         self.assertNotContains(save_page, "domain registrants must maintain accurate contact information")
 
@@ -902,55 +895,38 @@ class UserProfileTests(TestWithUser, WebTest):
         DomainInformation.objects.all().delete()
 
     @less_console_noise_decorator
-    def error_500_main_nav_with_profile_feature_turned_on(self):
+    def error_500_main_nav(self):
-        """test that Your profile is in main nav of 500 error page when profile_feature is on.
+        """test that Your profile is in main nav of 500 error page.
 
         Our treatment of 401 and 403 error page handling with that waffle feature is similar, so we
         assume that the same test results hold true for 401 and 403."""
-        with override_flag("profile_feature", active=True):
         with self.assertRaises(Exception):
             response = self.client.get(reverse("home"), follow=True)
             self.assertEqual(response.status_code, 500)
             self.assertContains(response, "Your profile")
 
     @less_console_noise_decorator
-    def error_500_main_nav_with_profile_feature_turned_off(self):
+    def test_home_page_main_nav(self):
-        """test that Your profile is not in main nav of 500 error page when profile_feature is off.
+        """test that Your profile is in main nav of home page"""
-
-        Our treatment of 401 and 403 error page handling with that waffle feature is similar, so we
-        assume that the same test results hold true for 401 and 403."""
-        with override_flag("profile_feature", active=False):
-            with self.assertRaises(Exception):
-                response = self.client.get(reverse("home"), follow=True)
-                self.assertEqual(response.status_code, 500)
-                self.assertNotContains(response, "Your profile")
-
-    @less_console_noise_decorator
-    def test_home_page_main_nav_with_profile_feature_on(self):
-        """test that Your profile is in main nav of home page when profile_feature is on"""
-        with override_flag("profile_feature", active=True):
         response = self.client.get("/", follow=True)
         self.assertContains(response, "Your profile")
 
     @less_console_noise_decorator
-    def test_new_request_main_nav_with_profile_feature_on(self):
+    def test_new_request_main_nav(self):
-        """test that Your profile is in main nav of new request when profile_feature is on"""
+        """test that Your profile is in main nav of new request"""
-        with override_flag("profile_feature", active=True):
         response = self.client.get("/request/", follow=True)
         self.assertContains(response, "Your profile")
 
     @less_console_noise_decorator
-    def test_user_profile_main_nav_with_profile_feature_on(self):
+    def test_user_profile_main_nav(self):
-        """test that Your profile is in main nav of user profile when profile_feature is on"""
+        """test that Your profile is in main nav of user profile"""
-        with override_flag("profile_feature", active=True):
         response = self.client.get("/user-profile", follow=True)
         self.assertContains(response, "Your profile")
 
     @less_console_noise_decorator
     def test_user_profile_back_button_when_coming_from_domain_request(self):
-        """tests user profile when profile_feature is on,
+        """tests user profile,
         and when they are redirected from the domain request page"""
-        with override_flag("profile_feature", active=True):
         response = self.client.get("/user-profile?redirect=domain-request:")
         self.assertContains(response, "Your profile")
         self.assertContains(response, "Go back to your domain request")
@@ -964,9 +940,8 @@ class UserProfileTests(TestWithUser, WebTest):
         self.assertNotContains(response, "Your contact information")
 
     @less_console_noise_decorator
-    def test_domain_your_contact_information_when_profile_feature_on(self):
+    def test_domain_your_contact_information(self):
         """test that Your contact information is not accessible when profile feature is on"""
-        with override_flag("profile_feature", active=True):
         response = self.client.get(f"/domain/{self.domain.id}/your-contact-information", follow=True)
         self.assertEqual(response.status_code, 404)