zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-23 11:16:07 +02:00
Code Issues Projects Releases Packages Wiki Activity

use update function to delete hosts

Browse source
This commit is contained in:
matthewswspence 2024-12-09 13:34:34 -06:00
parent 5e7823a6ec
commit e87c4f78f1
No known key found for this signature in database
GPG key ID: FB458202A7852BA4
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/registrar/models/domain.py
View file

@ -1074,8 +1074,9 @@ class Domain(TimeStampedModel, DomainHelper):
hostsToDelete, _ = self.createDeleteHostList(nameservers)
logger.debug("HostsToDelete from %s inside _delete_subdomains -> %s", self.name, hostsToDelete)
for objSet in hostsToDelete:
self._delete_hosts_if_not_used(objSet.hosts)
self.addAndRemoveHostsFromDomain(None, hostsToDelete=nameservers)
# for objSet in hostsToDelete:
# self._delete_hosts_if_not_used(objSet.hosts)
def _delete_domain(self):
"""This domain should be deleted from the registry

2
src/registrar/tests/test_admin_domain.py
View file

@ -228,7 +228,7 @@ class TestDomainAdminAsStaff(MockEppLib):
"""
Scenario: Domain deletion is unsuccessful
When the domain is deleted and has shared subdomains
Then a user-friendly success message is returned for displaying on the web
Then a user-friendly error message is returned for displaying on the web
And `state` is not set to `DELETED`
"""
domain, _ = Domain.objects.get_or_create(name="sharingiscaring.gov", state=Domain.State.ON_HOLD)