diff --git a/src/registrar/models/domain.py b/src/registrar/models/domain.py index ba4db0ef9..6cd8f4f54 100644 --- a/src/registrar/models/domain.py +++ b/src/registrar/models/domain.py @@ -449,11 +449,11 @@ class Domain(TimeStampedModel, DomainHelper): oldNameservers, ) = self.getNameserverChanges(hosts=hosts) + successCreatedCount = self._new_host_values(new_values) successDeletedCount = self._deleted_host_values(deleted_values) # returns value _ = self._update_host_values( updated_values, oldNameservers ) # returns nothing, just need to be run and errors - successCreatedCount = self._new_host_values(new_values) successTotalNameservers = ( len(oldNameservers) - successDeletedCount + successCreatedCount diff --git a/src/registrar/tests/test_models_domain.py b/src/registrar/tests/test_models_domain.py index 5cdd3c79d..60f7a3e14 100644 --- a/src/registrar/tests/test_models_domain.py +++ b/src/registrar/tests/test_models_domain.py @@ -1094,7 +1094,7 @@ class TestRegistrantNameservers(MockEppLib): ] self.mockedSendFunction.assert_has_calls(expectedCalls, any_order=True) - self.assertTrue(self.domain.is_active()) + self.assertTrue(self.domainWithThreeNS.is_active()) def test_user_removes_too_many_nameservers(self): """ @@ -1145,7 +1145,7 @@ class TestRegistrantNameservers(MockEppLib): ] self.mockedSendFunction.assert_has_calls(expectedCalls, any_order=True) - self.assertFalse(self.domain.is_active()) + self.assertFalse(self.domainWithThreeNS.is_active()) def test_user_replaces_nameservers(self): """ @@ -1157,7 +1157,7 @@ class TestRegistrantNameservers(MockEppLib): And `commands.UpdateDomain` is sent to add #4 and #5 plus remove #2 and #3 And `commands.DeleteHost` is sent to delete #2 and #3 """ - + print("in second failing test") self.domainWithThreeNS.nameservers = [ (self.nameserver1,), ("ns1.cats-are-superior1.com",), @@ -1220,7 +1220,7 @@ class TestRegistrantNameservers(MockEppLib): ] self.mockedSendFunction.assert_has_calls(expectedCalls, any_order=True) - self.assertTrue(self.domain.is_active()) + self.assertTrue(self.domainWithThreeNS.is_active()) def test_user_cannot_add_subordinate_without_ip(self): """ @@ -1395,6 +1395,7 @@ class TestRegistrantNameservers(MockEppLib): domain.nameservers = [("ns1.failednameserver.gov", ["4.5.6"])] def tearDown(self): + print("in tear down") Domain.objects.all().delete() return super().tearDown()