zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-24 21:29:53 +02:00
Code Issues Projects Releases Packages Wiki Activity

removed unneeded comments and updated others

Browse source
This commit is contained in:
Alysia Broddrick 2023-09-11 06:04:21 -07:00
parent d476a1b377
commit e6b94e83a4
No known key found for this signature in database
GPG key ID: 03917052CD0F06B7
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/registrar/tests/test_models_domain.py
View file

@ -48,9 +48,10 @@ class MockEppLib(TestCase):
) )
def mockSend(self, _request, cleaned): def mockSend(self, _request, cleaned):
"""""" """Mocks the registry.send function used inside of domain.py
print("in mock send patch is ") registry is imported from epplibwrapper
print(_request) returns objects that simulate what would be in a epp response
but only relevant pieces for tests"""
if isinstance(_request, commands.InfoDomain): if isinstance(_request, commands.InfoDomain):
if getattr(_request, "name", None) == "security.gov": if getattr(_request, "name", None) == "security.gov":
return MagicMock(res_data=[self.infoDomainNoContact]) return MagicMock(res_data=[self.infoDomainNoContact])
@ -62,8 +63,8 @@ class MockEppLib(TestCase):
and getattr(_request, "id", None) == "fail" and getattr(_request, "id", None) == "fail"
and self.mockedSendFunction.call_count == 3 and self.mockedSendFunction.call_count == 3
): ):
print("raising error") #use this for when a contact is being updated
#sets the second send() to fail
raise RegistryError(code=ErrorCode.OBJECT_EXISTS) raise RegistryError(code=ErrorCode.OBJECT_EXISTS)
return MagicMock(res_data=[self.mockDataInfoHosts]) return MagicMock(res_data=[self.mockDataInfoHosts])

3
src/registrar/views/domain.py
View file

@ -272,13 +272,12 @@ class DomainSecurityEmailView(DomainPermissionView, FormMixin):
# Set the security email from the form # Set the security email from the form
new_email = form.cleaned_data.get("security_email", "") new_email = form.cleaned_data.get("security_email", "")
domain = self.get_object() domain = self.get_object()
contact = domain.security_contact contact = domain.security_contact
contact.email = new_email contact.email = new_email
contact.save() contact.save()
##update security email here
# call the setter
messages.success( messages.success(
self.request, "The security email for this domain have been updated." self.request, "The security email for this domain have been updated."
) )