zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-14 16:47:02 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2375 from cisagov/meoward/2278-move-rejection-reason

Browse source 
(on getgov-meoward) Ticket #2278: Change the rejection reason field error message
This commit is contained in:
zandercymatics 2024-06-27 14:27:59 -06:00 • committed by GitHub
commit e668dc23c9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/registrar/tests/test_admin.py
View file

@ -944,7 +944,7 @@ class TestDomainRequestAdminForm(TestCase):
self.assertIn("rejection_reason", form.errors) self.assertIn("rejection_reason", form.errors)
rejection_reason = form.errors.get("rejection_reason") rejection_reason = form.errors.get("rejection_reason")
self.assertEqual(rejection_reason, ["A rejection reason is required."]) self.assertEqual(rejection_reason, ["A reason is required for this status."])
def test_form_choices_when_no_instance(self): def test_form_choices_when_no_instance(self):
with less_console_noise(): with less_console_noise():
@ -1929,7 +1929,7 @@ class TestDomainRequestAdmin(MockEppLib):
messages.error.assert_called_once_with( messages.error.assert_called_once_with(
request, request,
"A rejection reason is required.", "A reason is required for this status.",
) )
domain_request.refresh_from_db() domain_request.refresh_from_db()

2
src/registrar/utility/errors.py
View file

@ -101,7 +101,7 @@ class FSMDomainRequestError(Exception):
FSMErrorCodes.NO_INVESTIGATOR: ("Investigator is required for this status."), FSMErrorCodes.NO_INVESTIGATOR: ("Investigator is required for this status."),
FSMErrorCodes.INVESTIGATOR_NOT_STAFF: ("Investigator is not a staff user."), FSMErrorCodes.INVESTIGATOR_NOT_STAFF: ("Investigator is not a staff user."),
FSMErrorCodes.INVESTIGATOR_NOT_SUBMITTER: ("Only the assigned investigator can make this change."), FSMErrorCodes.INVESTIGATOR_NOT_SUBMITTER: ("Only the assigned investigator can make this change."),
FSMErrorCodes.NO_REJECTION_REASON: ("A rejection reason is required."), FSMErrorCodes.NO_REJECTION_REASON: ("A reason is required for this status."),
FSMErrorCodes.NO_ACTION_NEEDED_REASON: ("A reason is required for this status."), FSMErrorCodes.NO_ACTION_NEEDED_REASON: ("A reason is required for this status."),
} }