zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-15 09:07:02 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix js, linting

Browse source
This commit is contained in:
zandercymatics 2024-04-22 09:55:05 -06:00
parent 4edb6ea988
commit e581d3b2ca
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
3 changed files with 20 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/registrar/assets/js/get-gov.js
View file

@ -213,7 +213,6 @@ function HookupYesNoListener(radioButtonName, elementIdToShowIfYes, elementIdToS
// Check if the element exists before accessing its value // Check if the element exists before accessing its value
let selectedValue = radioButtonChecked ? radioButtonChecked.value : null; let selectedValue = radioButtonChecked ? radioButtonChecked.value : null;
if (elementIdToShowIfYes && elementIdToShowIfNo){
switch (selectedValue) { switch (selectedValue) {
case 'True': case 'True':
toggleTwoDomElements(elementIdToShowIfYes, elementIdToShowIfNo, 1); toggleTwoDomElements(elementIdToShowIfYes, elementIdToShowIfNo, 1);
@ -226,9 +225,6 @@ function HookupYesNoListener(radioButtonName, elementIdToShowIfYes, elementIdToS
default: default:
toggleTwoDomElements(elementIdToShowIfYes, elementIdToShowIfNo, 0); toggleTwoDomElements(elementIdToShowIfYes, elementIdToShowIfNo, 0);
} }
}else {
console.log("No elements to show")
}
} }
if (radioButtons.length) { if (radioButtons.length) {

9
src/registrar/models/domain_request.py
View file

@ -1103,7 +1103,14 @@ class DomainRequest(TimeStampedModel):
return self.other_contacts.exists() return self.other_contacts.exists()
def has_additional_details(self) -> bool: def has_additional_details(self) -> bool:
return self.has_anything_else_text() or self.has_cisa_representative """Combines the has_anything_else_text and has_cisa_representative fields,
then returns if this domain request has either of them."""
# Split out for linter
has_details = False
if self.has_anything_else_text or self.has_cisa_representative:
has_details = True
return has_details
def is_federal(self) -> Union[bool, None]: def is_federal(self) -> Union[bool, None]:
"""Is this domain request for a federal agency? """Is this domain request for a federal agency?

5
src/registrar/tests/test_views_request.py
View file

@ -1037,8 +1037,9 @@ class DomainRequestTests(TestWithUser, WebTest):
self.app.set_cookie(settings.SESSION_COOKIE_NAME, session_id) self.app.set_cookie(settings.SESSION_COOKIE_NAME, session_id)
# We expect to see this twice for both fields # We expect to see this twice for both fields. This results in a count of 4
self.assertContains(response, "This question is required.", count=2) # due to screen reader information / html.
self.assertContains(response, "This question is required.", count=4)
def test_submitting_other_contacts_deletes_no_other_contacts_rationale(self): def test_submitting_other_contacts_deletes_no_other_contacts_rationale(self):
"""When a user submits the Other Contacts form with other contacts selected, the domain request's """When a user submits the Other Contacts form with other contacts selected, the domain request's