zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-20 03:19:24 +02:00
Code Issues Projects Releases Packages Wiki Activity

possible fix for blanks around datafile delimiters

Browse source
This commit is contained in:
CocoByte 2023-11-07 15:59:11 -06:00
parent cb9b135178
commit e4b90e7dfe
No known key found for this signature in database
GPG key ID: BBFAA2526384C97F
1 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/registrar/management/commands/utility/extra_transition_domain_helper.py
View file

@ -895,14 +895,16 @@ class ExtraTransitionDomain:
def _read_csv_file(self, file, seperator, dataclass_type, id_field): def _read_csv_file(self, file, seperator, dataclass_type, id_field):
with open(file, "r", encoding="utf-8-sig") as requested_file: with open(file, "r", encoding="utf-8-sig") as requested_file:
reader = csv.DictReader(requested_file, delimiter=seperator) reader = csv.DictReader(requested_file, skipinitialspace=True, delimiter=seperator)
dict_data = {} dict_data = {}
for row in reader: for row in reader:
# cleaned_row, cleaning_was_needed = self.clean_delimiters()
if None in row: if None in row:
print("Skipping row with None key") logger.info("Skipping row with None key")
print(dataclass_type) logger.info(dataclass_type)
for key, value in row.items(): for key, value in row.items():
print(f"key: {key} value: {value}") logger.info(f"key: {key} value: {value}")
TerminalHelper.prompt_for_execution(False, "COnintue?", "DEBUG")
continue continue
row_id = row[id_field] row_id = row[id_field]
@ -914,3 +916,16 @@ class ExtraTransitionDomain:
# dict_data = {row[id_field]: dataclass_type(**row) for row in reader} # dict_data = {row[id_field]: dataclass_type(**row) for row in reader}
return dict_data return dict_data
# def clean_delimiters(self, data_row) -> (str, bool):
# """ This function was created to prevent errors where data files had spaces
# erroneously injected around the delimiters. """
# cleaning_was_needed = False
# TerminalHelper.print_conditional(cleaning_was_needed,
# (f"{TerminalColors.YELLOW}"
# f"WARNING: Data file has spaces"
# f"around the delimiters. Removing"
# f"erroneous spaces..."
# f"{TerminalColors.ENDC}"))