zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-14 21:44:08 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge branch 'main' into dk/3353-duplicate-users

Browse source
This commit is contained in:
David Kennedy 2025-01-29 05:30:15 -05:00
commit e44ef70b89
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
27 changed files with 277 additions and 118 deletions
Download patch file Download diff file Expand all files Collapse all files

15
docs/operations/data_migration.md
View file

@ -907,13 +907,14 @@ Example (only requests): `./manage.py create_federal_portfolio --branch "executi
```docker-compose exec app ./manage.py create_federal_portfolio --agency_name "{federal_agency_name}" --both``` ```docker-compose exec app ./manage.py create_federal_portfolio --agency_name "{federal_agency_name}" --both```
##### Parameters ##### Parameters
| | Parameter | Description | | | Parameter | Description |
|:-:|:-------------------------- |:-------------------------------------------------------------------------------------------| |:-:|:---------------------------- |:-------------------------------------------------------------------------------------------|
| 1 | **agency_name** | Name of the FederalAgency record surrounded by quotes. For instance,"AMTRAK". | | 1 | **agency_name** | Name of the FederalAgency record surrounded by quotes. For instance,"AMTRAK". |
| 2 | **branch** | Creates a portfolio for each federal agency in a branch: executive, legislative, judicial | | 2 | **branch** | Creates a portfolio for each federal agency in a branch: executive, legislative, judicial |
| 3 | **both** | If True, runs parse_requests and parse_domains. | | 3 | **both** | If True, runs parse_requests and parse_domains. |
| 4 | **parse_requests** | If True, then the created portfolio is added to all related DomainRequests. | | 4 | **parse_requests** | If True, then the created portfolio is added to all related DomainRequests. |
| 5 | **parse_domains** | If True, then the created portfolio is added to all related Domains. | | 5 | **parse_domains** | If True, then the created portfolio is added to all related Domains. |
| 6 | **skip_existing_portfolios** | If True, then the script will only create suborganizations, modify DomainRequest, and modify DomainInformation records only when creating a new portfolio. Use this flag when you do not want to modify existing records. |
- Parameters #1-#2: Either `--agency_name` or `--branch` must be specified. Not both. - Parameters #1-#2: Either `--agency_name` or `--branch` must be specified. Not both.
- Parameters #2-#3, you cannot use `--both` while using these. You must specify either `--parse_requests` or `--parse_domains` seperately. While all of these parameters are optional in that you do not need to specify all of them, - Parameters #2-#3, you cannot use `--both` while using these. You must specify either `--parse_requests` or `--parse_domains` seperately. While all of these parameters are optional in that you do not need to specify all of them,

4
src/registrar/assets/src/js/getgov/portfolio-member-page.js
View file

@ -18,11 +18,11 @@ export function initPortfolioNewMemberPageToggle() {
const unique_id = `${member_type}-${member_id}`; const unique_id = `${member_type}-${member_id}`;
let cancelInvitationButton = member_type === "invitedmember" ? "Cancel invitation" : "Remove member"; let cancelInvitationButton = member_type === "invitedmember" ? "Cancel invitation" : "Remove member";
wrapperDeleteAction.innerHTML = generateKebabHTML('remove-member', unique_id, cancelInvitationButton, `for ${member_name}`); wrapperDeleteAction.innerHTML = generateKebabHTML('remove-member', unique_id, cancelInvitationButton, `More Options for ${member_name}`);
// This easter egg is only for fixtures that dont have names as we are displaying their emails // This easter egg is only for fixtures that dont have names as we are displaying their emails
// All prod users will have emails linked to their account // All prod users will have emails linked to their account
MembersTable.addMemberModal(num_domains, member_email || "Samwise Gamgee", member_delete_url, unique_id, wrapperDeleteAction); MembersTable.addMemberDeleteModal(num_domains, member_email || member_name || "Samwise Gamgee", member_delete_url, unique_id, wrapperDeleteAction);
uswdsInitializeModals(); uswdsInitializeModals();

7
src/registrar/assets/src/js/getgov/table-base.js
View file

@ -93,7 +93,6 @@ export function generateKebabHTML(action, unique_id, modal_button_text, screen_r
<use xlink:href="/public/img/sprite.svg#delete"></use> <use xlink:href="/public/img/sprite.svg#delete"></use>
</svg>` : ''} </svg>` : ''}
${modal_button_text} ${modal_button_text}
<span class="usa-sr-only">${screen_reader_text}</span>
</a> </a>
`; `;
@ -107,6 +106,7 @@ export function generateKebabHTML(action, unique_id, modal_button_text, screen_r
class="usa-button usa-button--unstyled usa-button--with-icon usa-accordion__button usa-button--more-actions" class="usa-button usa-button--unstyled usa-button--with-icon usa-accordion__button usa-button--more-actions"
aria-expanded="false" aria-expanded="false"
aria-controls="more-actions-${unique_id}" aria-controls="more-actions-${unique_id}"
aria-label="${screen_reader_text}"
> >
<svg class="usa-icon top-2px" aria-hidden="true" focusable="false" role="img" width="24"> <svg class="usa-icon top-2px" aria-hidden="true" focusable="false" role="img" width="24">
<use xlink:href="/public/img/sprite.svg#more_vert"></use> <use xlink:href="/public/img/sprite.svg#more_vert"></use>
@ -284,15 +284,18 @@ export class BaseTable {
showElement(dataWrapper); showElement(dataWrapper);
hideElement(noSearchResultsWrapper); hideElement(noSearchResultsWrapper);
hideElement(noDataWrapper); hideElement(noDataWrapper);
this.tableAnnouncementRegion.innerHTML = '';
} else { } else {
hideElement(dataWrapper); hideElement(dataWrapper);
showElement(noSearchResultsWrapper); showElement(noSearchResultsWrapper);
hideElement(noDataWrapper); hideElement(noDataWrapper);
this.tableAnnouncementRegion.innerHTML = this.noSearchResultsWrapper.innerHTML;
} }
} else { } else {
hideElement(dataWrapper); hideElement(dataWrapper);
hideElement(noSearchResultsWrapper); hideElement(noSearchResultsWrapper);
showElement(noDataWrapper); showElement(noDataWrapper);
this.tableAnnouncementRegion.innerHTML = this.noDataWrapper.innerHTML;
} }
}; };
@ -448,6 +451,7 @@ export class BaseTable {
const baseUrlValue = this.getBaseUrl()?.innerHTML ?? null; const baseUrlValue = this.getBaseUrl()?.innerHTML ?? null;
if (!baseUrlValue) return; if (!baseUrlValue) return;
this.tableAnnouncementRegion.innerHTML = '<p>Loading table.</p>';
let url = `${baseUrlValue}?${searchParams.toString()}` let url = `${baseUrlValue}?${searchParams.toString()}`
fetch(url) fetch(url)
.then(response => response.json()) .then(response => response.json())
@ -469,7 +473,6 @@ export class BaseTable {
let dataObjects = this.getDataObjects(data); let dataObjects = this.getDataObjects(data);
let customTableOptions = this.customizeTable(data); let customTableOptions = this.customizeTable(data);
dataObjects.forEach(dataObject => { dataObjects.forEach(dataObject => {
this.addRow(dataObject, tbody, customTableOptions); this.addRow(dataObject, tbody, customTableOptions);
}); });

23
src/registrar/assets/src/js/getgov/table-edit-member-domains.js
View file

@ -103,8 +103,9 @@ export class EditMemberDomainsTable extends BaseTable {
disabled = true; disabled = true;
} }
// uses margin-right-neg-5 as a hack to increase the text-wrapping width on this table
row.innerHTML = ` row.innerHTML = `
<td data-label="Selection" data-sort-value="0" class="padding-right-105"> <th scope="row" role="rowheader" data-label="Selection" data-sort-value="0" class="padding-right-105">
<div class="usa-checkbox"> <div class="usa-checkbox">
<input <input
class="usa-checkbox__input" class="usa-checkbox__input"
@ -112,6 +113,7 @@ export class EditMemberDomainsTable extends BaseTable {
type="checkbox" type="checkbox"
name="${domain.name}" name="${domain.name}"
value="${domain.id}" value="${domain.id}"
aria-label="${domain.name}"
${checked ? 'checked' : ''} ${checked ? 'checked' : ''}
${disabled ? 'disabled' : ''} ${disabled ? 'disabled' : ''}
/> />
@ -119,10 +121,10 @@ export class EditMemberDomainsTable extends BaseTable {
<span class="sr-only">${domain.id}</span> <span class="sr-only">${domain.id}</span>
</label> </label>
</div> </div>
</td> </th>
<td data-label="Domain name"> <td data-label="Domain name">
${domain.name} ${domain.name}
${disabled ? '<span class="display-block margin-top-05 text-gray-50">Domains must have one domain manager. To unassign this member, the domain needs another domain manager.</span>' : ''} ${disabled ? '<span class="display-block margin-top-05 text-gray-50 margin-right-neg-5">Domains must have one domain manager. To unassign this member, the domain needs another domain manager.</span>' : ''}
</td> </td>
`; `;
tbody.appendChild(row); tbody.appendChild(row);
@ -235,7 +237,8 @@ export class EditMemberDomainsTable extends BaseTable {
// Create unassigned domains list // Create unassigned domains list
const unassignedDomainsList = document.createElement('ul'); const unassignedDomainsList = document.createElement('ul');
unassignedDomainsList.classList.add('usa-list', 'usa-list--unstyled'); unassignedDomainsList.classList.add('usa-list', 'usa-list--unstyled');
this.removedDomains.forEach(removedDomain => { let removedDomainsCopy = [...this.removedDomains].sort((a, b) => a.name.localeCompare(b.name));
removedDomainsCopy.forEach(removedDomain => {
const removedDomainListItem = document.createElement('li'); const removedDomainListItem = document.createElement('li');
removedDomainListItem.textContent = removedDomain.name; // Use textContent for security removedDomainListItem.textContent = removedDomain.name; // Use textContent for security
unassignedDomainsList.appendChild(removedDomainListItem); unassignedDomainsList.appendChild(removedDomainListItem);
@ -244,7 +247,8 @@ export class EditMemberDomainsTable extends BaseTable {
// Create assigned domains list // Create assigned domains list
const assignedDomainsList = document.createElement('ul'); const assignedDomainsList = document.createElement('ul');
assignedDomainsList.classList.add('usa-list', 'usa-list--unstyled'); assignedDomainsList.classList.add('usa-list', 'usa-list--unstyled');
this.addedDomains.forEach(addedDomain => { let addedDomainsCopy = [...this.addedDomains].sort((a, b) => a.name.localeCompare(b.name));
addedDomainsCopy.forEach(addedDomain => {
const addedDomainListItem = document.createElement('li'); const addedDomainListItem = document.createElement('li');
addedDomainListItem.textContent = addedDomain.name; // Use textContent for security addedDomainListItem.textContent = addedDomain.name; // Use textContent for security
assignedDomainsList.appendChild(addedDomainListItem); assignedDomainsList.appendChild(addedDomainListItem);
@ -259,7 +263,7 @@ export class EditMemberDomainsTable extends BaseTable {
// Append unassigned domains section // Append unassigned domains section
if (this.removedDomains.length) { if (this.removedDomains.length) {
const unassignedHeader = document.createElement('h3'); const unassignedHeader = document.createElement('h3');
unassignedHeader.classList.add('margin-bottom-1'); unassignedHeader.classList.add('margin-bottom-05', 'h4');
unassignedHeader.textContent = 'Unassigned domains'; unassignedHeader.textContent = 'Unassigned domains';
domainAssignmentSummary.appendChild(unassignedHeader); domainAssignmentSummary.appendChild(unassignedHeader);
domainAssignmentSummary.appendChild(unassignedDomainsList); domainAssignmentSummary.appendChild(unassignedDomainsList);
@ -268,7 +272,8 @@ export class EditMemberDomainsTable extends BaseTable {
// Append assigned domains section // Append assigned domains section
if (this.addedDomains.length) { if (this.addedDomains.length) {
const assignedHeader = document.createElement('h3'); const assignedHeader = document.createElement('h3');
assignedHeader.classList.add('margin-bottom-1'); // Make this h3 look like a h4
assignedHeader.classList.add('margin-bottom-05', 'h4');
assignedHeader.textContent = 'Assigned domains'; assignedHeader.textContent = 'Assigned domains';
domainAssignmentSummary.appendChild(assignedHeader); domainAssignmentSummary.appendChild(assignedHeader);
domainAssignmentSummary.appendChild(assignedDomainsList); domainAssignmentSummary.appendChild(assignedDomainsList);
@ -276,7 +281,8 @@ export class EditMemberDomainsTable extends BaseTable {
// Append total assigned domains section // Append total assigned domains section
const totalHeader = document.createElement('h3'); const totalHeader = document.createElement('h3');
totalHeader.classList.add('margin-bottom-1'); // Make this h3 look like a h4
totalHeader.classList.add('margin-bottom-05', 'h4');
totalHeader.textContent = 'Total assigned domains'; totalHeader.textContent = 'Total assigned domains';
domainAssignmentSummary.appendChild(totalHeader); domainAssignmentSummary.appendChild(totalHeader);
const totalCount = document.createElement('p'); const totalCount = document.createElement('p');
@ -289,6 +295,7 @@ export class EditMemberDomainsTable extends BaseTable {
this.updateReadonlyDisplay(); this.updateReadonlyDisplay();
hideElement(this.editModeContainer); hideElement(this.editModeContainer);
showElement(this.readonlyModeContainer); showElement(this.readonlyModeContainer);
window.scrollTo(0, 0);
} }
showEditMode() { showEditMode() {

4
src/registrar/assets/src/js/getgov/table-member-domains.js
View file

@ -19,9 +19,9 @@ export class MemberDomainsTable extends BaseTable {
const domain = dataObject; const domain = dataObject;
const row = document.createElement('tr'); const row = document.createElement('tr');
row.innerHTML = ` row.innerHTML = `
<td scope="row" data-label="Domain name"> <th scope="row" role="rowheader" data-label="Domain name">
${domain.name} ${domain.name}
</td> </th>
`; `;
tbody.appendChild(row); tbody.appendChild(row);
} }

59
src/registrar/assets/src/js/getgov/table-members.js
View file

@ -78,13 +78,12 @@ export class MembersTable extends BaseTable {
const num_domains = member.domain_urls.length; const num_domains = member.domain_urls.length;
const last_active = this.handleLastActive(member.last_active); const last_active = this.handleLastActive(member.last_active);
let cancelInvitationButton = member.type === "invitedmember" ? "Cancel invitation" : "Remove member"; let cancelInvitationButton = member.type === "invitedmember" ? "Cancel invitation" : "Remove member";
const kebabHTML = customTableOptions.hasAdditionalActions ? generateKebabHTML('remove-member', unique_id, cancelInvitationButton, `for ${member.name}`): ''; const kebabHTML = customTableOptions.hasAdditionalActions ? generateKebabHTML('remove-member', unique_id, cancelInvitationButton, `Expand for more options for ${member.name}`): '';
const row = document.createElement('tr'); const row = document.createElement('tr');
let admin_tagHTML = ``; let admin_tagHTML = ``;
if (member.is_admin) if (member.is_admin)
admin_tagHTML = `<span class="usa-tag margin-left-1 bg-primary">Admin</span>` admin_tagHTML = `<span class="usa-tag margin-left-1 bg-primary-dark text-semibold">Admin</span>`
// generate html blocks for domains and permissions for the member // generate html blocks for domains and permissions for the member
let domainsHTML = this.generateDomainsHTML(num_domains, member.domain_names, member.domain_urls, member.action_url); let domainsHTML = this.generateDomainsHTML(num_domains, member.domain_names, member.domain_urls, member.action_url);
@ -99,7 +98,8 @@ export class MembersTable extends BaseTable {
type="button" type="button"
class="usa-button--show-more-button usa-button usa-button--unstyled display-block margin-top-1" class="usa-button--show-more-button usa-button usa-button--unstyled display-block margin-top-1"
data-for=${unique_id} data-for=${unique_id}
aria-label="Expand for additional information" aria-label="Expand for additional information for ${member.member_display}"
aria-label-placeholder="${member.member_display}"
> >
<span>Expand</span> <span>Expand</span>
<svg class="usa-icon usa-icon--large" aria-hidden="true" focusable="false" role="img" width="24"> <svg class="usa-icon usa-icon--large" aria-hidden="true" focusable="false" role="img" width="24">
@ -137,7 +137,7 @@ export class MembersTable extends BaseTable {
} }
// This easter egg is only for fixtures that dont have names as we are displaying their emails // This easter egg is only for fixtures that dont have names as we are displaying their emails
// All prod users will have emails linked to their account // All prod users will have emails linked to their account
if (customTableOptions.hasAdditionalActions) MembersTable.addMemberDeleteModal(num_domains, member.email || "Samwise Gamgee", member_delete_url, unique_id, row); if (customTableOptions.hasAdditionalActions) MembersTable.addMemberDeleteModal(num_domains, member.email || member.name || "Samwise Gamgee", member_delete_url, unique_id, row);
} }
/** /**
@ -166,13 +166,27 @@ export class MembersTable extends BaseTable {
spanElement.textContent = 'Close'; spanElement.textContent = 'Close';
useElement.setAttribute('xlink:href', '/public/img/sprite.svg#expand_less'); useElement.setAttribute('xlink:href', '/public/img/sprite.svg#expand_less');
buttonParentRow.classList.add('hide-td-borders'); buttonParentRow.classList.add('hide-td-borders');
toggleButton.setAttribute('aria-label', 'Close additional information');
let ariaLabelText = "Close additional information";
let ariaLabelPlaceholder = toggleButton.getAttribute("aria-label-placeholder");
if (ariaLabelPlaceholder) {
ariaLabelText = `Close additional information for ${ariaLabelPlaceholder}`;
}
toggleButton.setAttribute('aria-label', ariaLabelText);
// Set tabindex for focusable elements in expanded content
} else { } else {
hideElement(contentDiv); hideElement(contentDiv);
spanElement.textContent = 'Expand'; spanElement.textContent = 'Expand';
useElement.setAttribute('xlink:href', '/public/img/sprite.svg#expand_more'); useElement.setAttribute('xlink:href', '/public/img/sprite.svg#expand_more');
buttonParentRow.classList.remove('hide-td-borders'); buttonParentRow.classList.remove('hide-td-borders');
toggleButton.setAttribute('aria-label', 'Expand for additional information');
let ariaLabelText = "Expand for additional information";
let ariaLabelPlaceholder = toggleButton.getAttribute("aria-label-placeholder");
if (ariaLabelPlaceholder) {
ariaLabelText = `Expand for additional information for ${ariaLabelPlaceholder}`;
}
toggleButton.setAttribute('aria-label', ariaLabelText);
} }
} }
@ -245,21 +259,19 @@ export class MembersTable extends BaseTable {
// Only generate HTML if the member has one or more assigned domains // Only generate HTML if the member has one or more assigned domains
if (num_domains > 0) { if (num_domains > 0) {
domainsHTML += "<div class='desktop:grid-col-5 margin-bottom-2 desktop:margin-bottom-0'>"; domainsHTML += "<div class='desktop:grid-col-5 margin-bottom-2 desktop:margin-bottom-0'>";
domainsHTML += "<h4 class='margin-y-0'>Domains assigned</h4>"; domainsHTML += "<h4 class='font-body-xs margin-y-0'>Domains assigned</h4>";
domainsHTML += `<p class='margin-y-0'>This member is assigned to ${num_domains} domains:</p>`; domainsHTML += `<p class='font-body-xs text-base-dark margin-y-0'>This member is assigned to ${num_domains} domain${num_domains > 1 ? 's' : ''}:</p>`;
domainsHTML += "<ul class='usa-list usa-list--unstyled margin-y-0'>"; domainsHTML += "<ul class='usa-list usa-list--unstyled margin-y-0'>";
// Display up to 6 domains with their URLs // Display up to 6 domains with their URLs
for (let i = 0; i < num_domains && i < 6; i++) { for (let i = 0; i < num_domains && i < 6; i++) {
domainsHTML += `<li><a href="${domain_urls[i]}">${domain_names[i]}</a></li>`; domainsHTML += `<li><a class="font-body-xs" href="${domain_urls[i]}">${domain_names[i]}</a></li>`;
} }
domainsHTML += "</ul>"; domainsHTML += "</ul>";
// If there are more than 6 domains, display a "View assigned domains" link // If there are more than 6 domains, display a "View assigned domains" link
if (num_domains >= 6) { domainsHTML += `<p class="font-body-xs"><a href="${action_url}/domains">View assigned domains</a></p>`;
domainsHTML += `<p><a href="${action_url}/domains">View assigned domains</a></p>`;
}
domainsHTML += "</div>"; domainsHTML += "</div>";
} }
@ -378,34 +390,37 @@ export class MembersTable extends BaseTable {
generatePermissionsHTML(member_permissions, UserPortfolioPermissionChoices) { generatePermissionsHTML(member_permissions, UserPortfolioPermissionChoices) {
let permissionsHTML = ''; let permissionsHTML = '';
// Define shared classes across elements for easier refactoring
let sharedParagraphClasses = "font-body-xs text-base-dark margin-top-1 p--blockquote";
// Check domain-related permissions // Check domain-related permissions
if (member_permissions.includes(UserPortfolioPermissionChoices.VIEW_ALL_DOMAINS)) { if (member_permissions.includes(UserPortfolioPermissionChoices.VIEW_ALL_DOMAINS)) {
permissionsHTML += "<p class='margin-top-1 p--blockquote'><strong class='text-base-dark'>Domains:</strong> Can view all organization domains. Can manage domains they are assigned to and edit information about the domain (including DNS settings).</p>"; permissionsHTML += `<p class='${sharedParagraphClasses}'><strong class='text-base-dark'>Domains:</strong> Can view all organization domains. Can manage domains they are assigned to and edit information about the domain (including DNS settings).</p>`;
} else if (member_permissions.includes(UserPortfolioPermissionChoices.VIEW_MANAGED_DOMAINS)) { } else if (member_permissions.includes(UserPortfolioPermissionChoices.VIEW_MANAGED_DOMAINS)) {
permissionsHTML += "<p class='margin-top-1 p--blockquote'><strong class='text-base-dark'>Domains:</strong> Can manage domains they are assigned to and edit information about the domain (including DNS settings).</p>"; permissionsHTML += `<p class='${sharedParagraphClasses}'><strong class='text-base-dark'>Domains:</strong> Can manage domains they are assigned to and edit information about the domain (including DNS settings).</p>`;
} }
// Check request-related permissions // Check request-related permissions
if (member_permissions.includes(UserPortfolioPermissionChoices.EDIT_REQUESTS)) { if (member_permissions.includes(UserPortfolioPermissionChoices.EDIT_REQUESTS)) {
permissionsHTML += "<p class='margin-top-1 p--blockquote'><strong class='text-base-dark'>Domain requests:</strong> Can view all organization domain requests. Can create domain requests and modify their own requests.</p>"; permissionsHTML += `<p class='${sharedParagraphClasses}'><strong class='text-base-dark'>Domain requests:</strong> Can view all organization domain requests. Can create domain requests and modify their own requests.</p>`;
} else if (member_permissions.includes(UserPortfolioPermissionChoices.VIEW_ALL_REQUESTS)) { } else if (member_permissions.includes(UserPortfolioPermissionChoices.VIEW_ALL_REQUESTS)) {
permissionsHTML += "<p class='margin-top-1 p--blockquote'><strong class='text-base-dark'>Domain requests (view-only):</strong> Can view all organization domain requests. Can't create or modify any domain requests.</p>"; permissionsHTML += `<p class='${sharedParagraphClasses}'><strong class='text-base-dark'>Domain requests (view-only):</strong> Can view all organization domain requests. Can't create or modify any domain requests.</p>`;
} }
// Check member-related permissions // Check member-related permissions
if (member_permissions.includes(UserPortfolioPermissionChoices.EDIT_MEMBERS)) { if (member_permissions.includes(UserPortfolioPermissionChoices.EDIT_MEMBERS)) {
permissionsHTML += "<p class='margin-top-1 p--blockquote'><strong class='text-base-dark'>Members:</strong> Can manage members including inviting new members, removing current members, and assigning domains to members.</p>"; permissionsHTML += `<p class='${sharedParagraphClasses}'><strong class='text-base-dark'>Members:</strong> Can manage members including inviting new members, removing current members, and assigning domains to members.</p>`;
} else if (member_permissions.includes(UserPortfolioPermissionChoices.VIEW_MEMBERS)) { } else if (member_permissions.includes(UserPortfolioPermissionChoices.VIEW_MEMBERS)) {
permissionsHTML += "<p class='margin-top-1 p--blockquote'><strong class='text-base-dark'>Members (view-only):</strong> Can view all organizational members. Can't manage any members.</p>"; permissionsHTML += `<p class='${sharedParagraphClasses}'><strong class='text-base-dark'>Members (view-only):</strong> Can view all organizational members. Can't manage any members.</p>`;
} }
// If no specific permissions are assigned, display a message indicating no additional permissions // If no specific permissions are assigned, display a message indicating no additional permissions
if (!permissionsHTML) { if (!permissionsHTML) {
permissionsHTML += "<p class='margin-top-1 p--blockquote'><b>No additional permissions:</b> There are no additional permissions for this member.</p>"; permissionsHTML += `<p class='${sharedParagraphClasses}'><b>No additional permissions:</b> There are no additional permissions for this member.</p>`;
} }
// Add a permissions header and wrap the entire output in a container // Add a permissions header and wrap the entire output in a container
permissionsHTML = "<div class='desktop:grid-col-7'><h4 class='margin-y-0'>Additional permissions for this member</h4>" + permissionsHTML + "</div>"; permissionsHTML = `<div class='desktop:grid-col-7'><h4 class='font-body-xs margin-y-0'>Additional permissions for this member</h4>${permissionsHTML}</div>`;
return permissionsHTML; return permissionsHTML;
} }
@ -423,7 +438,7 @@ export class MembersTable extends BaseTable {
let modalDescription = ``; let modalDescription = ``;
if (num_domains >= 0){ if (num_domains >= 0){
modalHeading = `Are you sure you want to delete ${member_email}?`; modalHeading = `Are you sure you want to remove ${member_email} from the organization?`;
modalDescription = `They will no longer be able to access this organization. modalDescription = `They will no longer be able to access this organization.
This action cannot be undone.`; This action cannot be undone.`;
if (num_domains >= 1) if (num_domains >= 1)

4
src/registrar/assets/src/sass/_theme/_buttons.scss
View file

@ -246,6 +246,10 @@ a.text-secondary:hover {
color: $theme-color-error; color: $theme-color-error;
} }
.usa-button.usa-button--secondary {
background-color: $theme-color-error;
}
.usa-button--show-more-button { .usa-button--show-more-button {
font-size: size('ui', 'xs'); font-size: size('ui', 'xs');
text-decoration: none; text-decoration: none;

5
src/registrar/assets/src/sass/_theme/_modals.scss Normal file
View file

@ -0,0 +1,5 @@
@use "uswds-core" as *;
.usa-modal__main {
padding: 0 2rem 2rem;
}

14
src/registrar/assets/src/sass/_theme/_tables.scss
View file

@ -41,6 +41,13 @@ th {
} }
} }
// The member table has an extra "expand" row, which looks like a single row.
// But the DOM disagrees - so we basically need to hide the border on both rows.
#members__table-wrapper .dotgov-table tr:nth-last-child(2) td,
#members__table-wrapper .dotgov-table tr:nth-last-child(2) th {
border-bottom: none;
}
.dotgov-table { .dotgov-table {
width: 100%; width: 100%;
@ -56,10 +63,9 @@ th {
border: none; border: none;
} }
tr:not(.hide-td-borders) { tr:not(.hide-td-borders):not(:last-child) td,
td, th { tr:not(.hide-td-borders):not(:last-child) th {
border-bottom: 1px solid color('base-lighter'); border-bottom: 1px solid color('base-lighter');
}
} }
thead th { thead th {

3
src/registrar/assets/src/sass/_theme/_tags.scss Normal file
View file

@ -0,0 +1,3 @@
.usa-tag {
text-transform: none;
}

1
src/registrar/assets/src/sass/_theme/_uswds-theme.scss
View file

@ -68,6 +68,7 @@ in the form $setting: value,
/*--------------------------- /*---------------------------
## Font weights ## Font weights
----------------------------*/ ----------------------------*/
$theme-font-weight-medium: 400,
$theme-font-weight-semibold: 600, $theme-font-weight-semibold: 600,
/*--------------------------- /*---------------------------

2
src/registrar/assets/src/sass/_theme/styles.scss
View file

@ -26,6 +26,8 @@
@forward "header"; @forward "header";
@forward "register-form"; @forward "register-form";
@forward "containers"; @forward "containers";
@forward "modals";
@forward "tags";
/*-------------------------------------------------- /*--------------------------------------------------
--- Admin ---------------------------------*/ --- Admin ---------------------------------*/

41
src/registrar/fixtures/fixtures_users.py
View file

@ -196,6 +196,7 @@ class UserFixture:
"username": "b6a15987-5c88-4e26-8de2-ca71a0bdb2cd", "username": "b6a15987-5c88-4e26-8de2-ca71a0bdb2cd",
"first_name": "Alysia-Analyst", "first_name": "Alysia-Analyst",
"last_name": "Alysia-Analyst", "last_name": "Alysia-Analyst",
"email": "abroddrick+1@truss.works",
}, },
{ {
"username": "91a9b97c-bd0a-458d-9823-babfde7ebf44", "username": "91a9b97c-bd0a-458d-9823-babfde7ebf44",
@ -361,22 +362,30 @@ class UserFixture:
@staticmethod @staticmethod
def _prepare_new_users(users, existing_usernames, existing_user_ids, are_superusers): def _prepare_new_users(users, existing_usernames, existing_user_ids, are_superusers):
return [ new_users = []
User( for i, user_data in enumerate(users):
id=user_data.get("id"), username = user_data.get("username")
first_name=user_data.get("first_name"), id = user_data.get("id")
last_name=user_data.get("last_name"), first_name = user_data.get("first_name", "Bob")
username=user_data.get("username"), last_name = user_data.get("last_name", "Builder")
email=user_data.get("email", ""),
title=user_data.get("title", "Peon"), default_email = f"placeholder.{first_name.lower()}.{last_name.lower()}+{i}@igorville.gov"
phone=user_data.get("phone", "2022222222"), email = user_data.get("email", default_email)
is_active=user_data.get("is_active", True), if username not in existing_usernames and id not in existing_user_ids:
is_staff=True, user = User(
is_superuser=are_superusers, id=id,
) first_name=first_name,
for user_data in users last_name=last_name,
if user_data.get("username") not in existing_usernames and user_data.get("id") not in existing_user_ids username=username,
] email=email,
title=user_data.get("title", "Peon"),
phone=user_data.get("phone", "2022222222"),
is_active=user_data.get("is_active", True),
is_staff=True,
is_superuser=are_superusers,
)
new_users.append(user)
return new_users
@staticmethod @staticmethod
def _create_new_users(new_users): def _create_new_users(new_users):

53
src/registrar/management/commands/create_federal_portfolio.py
View file

@ -64,6 +64,11 @@ class Command(BaseCommand):
action=argparse.BooleanOptionalAction, action=argparse.BooleanOptionalAction,
help="Adds portfolio to both requests and domains", help="Adds portfolio to both requests and domains",
) )
parser.add_argument(
"--skip_existing_portfolios",
action=argparse.BooleanOptionalAction,
help="Only add suborganizations to newly created portfolios, skip existing ones.",
)
def handle(self, **options): def handle(self, **options):
agency_name = options.get("agency_name") agency_name = options.get("agency_name")
@ -71,6 +76,7 @@ class Command(BaseCommand):
parse_requests = options.get("parse_requests") parse_requests = options.get("parse_requests")
parse_domains = options.get("parse_domains") parse_domains = options.get("parse_domains")
both = options.get("both") both = options.get("both")
skip_existing_portfolios = options.get("skip_existing_portfolios")
if not both: if not both:
if not parse_requests and not parse_domains: if not parse_requests and not parse_domains:
@ -97,7 +103,9 @@ class Command(BaseCommand):
TerminalHelper.colorful_logger(logger.info, TerminalColors.MAGENTA, message) TerminalHelper.colorful_logger(logger.info, TerminalColors.MAGENTA, message)
try: try:
# C901 'Command.handle' is too complex (12) # C901 'Command.handle' is too complex (12)
portfolio = self.handle_populate_portfolio(federal_agency, parse_domains, parse_requests, both) portfolio = self.handle_populate_portfolio(
federal_agency, parse_domains, parse_requests, both, skip_existing_portfolios
)
portfolios.append(portfolio) portfolios.append(portfolio)
except Exception as exec: except Exception as exec:
self.failed_portfolios.add(federal_agency) self.failed_portfolios.add(federal_agency)
@ -109,26 +117,33 @@ class Command(BaseCommand):
updated_suborg_count = self.post_process_all_suborganization_fields(agencies) updated_suborg_count = self.post_process_all_suborganization_fields(agencies)
message = f"Added city and state_territory information to {updated_suborg_count} suborgs." message = f"Added city and state_territory information to {updated_suborg_count} suborgs."
TerminalHelper.colorful_logger(logger.info, TerminalColors.MAGENTA, message) TerminalHelper.colorful_logger(logger.info, TerminalColors.MAGENTA, message)
TerminalHelper.log_script_run_summary( TerminalHelper.log_script_run_summary(
self.updated_portfolios, self.updated_portfolios,
self.failed_portfolios, self.failed_portfolios,
self.skipped_portfolios, self.skipped_portfolios,
debug=False, debug=False,
skipped_header="----- SOME PORTFOLIOS WERENT CREATED -----", log_header="============= FINISHED HANDLE PORTFOLIO STEP ===============",
skipped_header="----- SOME PORTFOLIOS WERENT CREATED (BUT OTHER RECORDS ARE STILL PROCESSED) -----",
display_as_str=True, display_as_str=True,
) )
# POST PROCESSING STEP: Remove the federal agency if it matches the portfolio name. # POST PROCESSING STEP: Remove the federal agency if it matches the portfolio name.
# We only do this for started domain requests. # We only do this for started domain requests.
if parse_requests or both: if parse_requests or both:
prompt_message = (
"This action will update domain requests even if they aren't on a portfolio."
"\nNOTE: This will modify domain requests, even if no portfolios were created."
"\nIn the event no portfolios *are* created, then this step will target "
"the existing portfolios with your given params."
"\nThis step is entirely optional, and is just for extra data cleanup."
)
TerminalHelper.prompt_for_execution( TerminalHelper.prompt_for_execution(
system_exit_on_terminate=True, system_exit_on_terminate=True,
prompt_message="This action will update domain requests even if they aren't on a portfolio.", prompt_message=prompt_message,
prompt_title=( prompt_title=(
"POST PROCESS STEP: Do you want to clear federal agency on (related) started domain requests?" "POST PROCESS STEP: Do you want to clear federal agency on (related) started domain requests?"
), ),
verify_message=None, verify_message="*** THIS STEP IS OPTIONAL ***",
) )
self.post_process_started_domain_requests(agencies, portfolios) self.post_process_started_domain_requests(agencies, portfolios)
@ -151,6 +166,11 @@ class Command(BaseCommand):
status=DomainRequest.DomainRequestStatus.STARTED, status=DomainRequest.DomainRequestStatus.STARTED,
organization_name__isnull=False, organization_name__isnull=False,
) )
if domain_requests_to_update.count() == 0:
TerminalHelper.colorful_logger(logger.info, TerminalColors.MAGENTA, "No domain requests to update.")
return
portfolio_set = {normalize_string(portfolio.organization_name) for portfolio in portfolios if portfolio} portfolio_set = {normalize_string(portfolio.organization_name) for portfolio in portfolios if portfolio}
# Update the request, assuming the given agency name matches the portfolio name # Update the request, assuming the given agency name matches the portfolio name
@ -173,10 +193,19 @@ class Command(BaseCommand):
DomainRequest.objects.bulk_update(updated_requests, ["federal_agency"]) DomainRequest.objects.bulk_update(updated_requests, ["federal_agency"])
TerminalHelper.colorful_logger(logger.info, TerminalColors.OKBLUE, "Action completed successfully.") TerminalHelper.colorful_logger(logger.info, TerminalColors.OKBLUE, "Action completed successfully.")
def handle_populate_portfolio(self, federal_agency, parse_domains, parse_requests, both): def handle_populate_portfolio(self, federal_agency, parse_domains, parse_requests, both, skip_existing_portfolios):
"""Attempts to create a portfolio. If successful, this function will """Attempts to create a portfolio. If successful, this function will
also create new suborganizations""" also create new suborganizations"""
portfolio, _ = self.create_portfolio(federal_agency) portfolio, created = self.create_portfolio(federal_agency)
if skip_existing_portfolios and not created:
TerminalHelper.colorful_logger(
logger.warning,
TerminalColors.YELLOW,
"Skipping modifications to suborgs, domain requests, and "
"domains due to the --skip_existing_portfolios flag. Portfolio already exists.",
)
return portfolio
self.create_suborganizations(portfolio, federal_agency) self.create_suborganizations(portfolio, federal_agency)
if parse_domains or both: if parse_domains or both:
self.handle_portfolio_domains(portfolio, federal_agency) self.handle_portfolio_domains(portfolio, federal_agency)
@ -283,15 +312,13 @@ class Command(BaseCommand):
DomainRequest.DomainRequestStatus.INELIGIBLE, DomainRequest.DomainRequestStatus.INELIGIBLE,
DomainRequest.DomainRequestStatus.REJECTED, DomainRequest.DomainRequestStatus.REJECTED,
] ]
domain_requests = DomainRequest.objects.filter(federal_agency=federal_agency, portfolio__isnull=True).exclude( domain_requests = DomainRequest.objects.filter(federal_agency=federal_agency).exclude(status__in=invalid_states)
status__in=invalid_states
)
if not domain_requests.exists(): if not domain_requests.exists():
message = f""" message = f"""
Portfolio '{portfolio}' not added to domain requests: no valid records found. Portfolio '{portfolio}' not added to domain requests: no valid records found.
This means that a filter on DomainInformation for the federal_agency '{federal_agency}' returned no results. This means that a filter on DomainInformation for the federal_agency '{federal_agency}' returned no results.
Excluded statuses: STARTED, INELIGIBLE, REJECTED. Excluded statuses: STARTED, INELIGIBLE, REJECTED.
Filter info: DomainRequest.objects.filter(federal_agency=federal_agency, portfolio__isnull=True).exclude( Filter info: DomainRequest.objects.filter(federal_agency=federal_agency).exclude(
status__in=invalid_states status__in=invalid_states
) )
""" """
@ -335,12 +362,12 @@ class Command(BaseCommand):
Returns a queryset of DomainInformation objects, or None if nothing changed. Returns a queryset of DomainInformation objects, or None if nothing changed.
""" """
domain_infos = DomainInformation.objects.filter(federal_agency=federal_agency, portfolio__isnull=True) domain_infos = DomainInformation.objects.filter(federal_agency=federal_agency)
if not domain_infos.exists(): if not domain_infos.exists():
message = f""" message = f"""
Portfolio '{portfolio}' not added to domains: no valid records found. Portfolio '{portfolio}' not added to domains: no valid records found.
The filter on DomainInformation for the federal_agency '{federal_agency}' returned no results. The filter on DomainInformation for the federal_agency '{federal_agency}' returned no results.
Filter info: DomainInformation.objects.filter(federal_agency=federal_agency, portfolio__isnull=True) Filter info: DomainInformation.objects.filter(federal_agency=federal_agency)
""" """
TerminalHelper.colorful_logger(logger.info, TerminalColors.YELLOW, message) TerminalHelper.colorful_logger(logger.info, TerminalColors.YELLOW, message)
return None return None

2
src/registrar/templates/django/admin/includes/portfolio/portfolio_members_table.html
View file

@ -30,7 +30,7 @@
<td>{{ member.user.phone }}</td> <td>{{ member.user.phone }}</td>
<td> <td>
{% for role in member.user|portfolio_role_summary:original %} {% for role in member.user|portfolio_role_summary:original %}
<span class="usa-tag">{{ role }}</span> <span class="usa-tag bg-primary-dark text-semibold">{{ role }}</span>
{% endfor %} {% endfor %}
</td> </td>
<td class="padding-left-1 text-size-small"> <td class="padding-left-1 text-size-small">

4
src/registrar/templates/domain_users.html
View file

@ -65,7 +65,7 @@
<tr> <tr>
<th scope="row" role="rowheader" data-sort-value="{{ item.permission.user.email }}" data-label="Email"> <th scope="row" role="rowheader" data-sort-value="{{ item.permission.user.email }}" data-label="Email">
{{ item.permission.user.email }} {{ item.permission.user.email }}
{% if item.has_admin_flag %}<span class="usa-tag margin-left-1 bg-primary">Admin</span>{% endif %} {% if item.has_admin_flag %}<span class="usa-tag margin-left-1 primary-dark text-semibold">Admin</span>{% endif %}
</th> </th>
{% if not portfolio %}<td data-label="Role">{{ item.permission.role|title }}</td>{% endif %} {% if not portfolio %}<td data-label="Role">{{ item.permission.role|title }}</td>{% endif %}
<td> <td>
@ -160,7 +160,7 @@
<tr> <tr>
<th scope="row" role="rowheader" data-sort-value="{{ invitation.domain_invitation.user.email }}" data-label="Email"> <th scope="row" role="rowheader" data-sort-value="{{ invitation.domain_invitation.user.email }}" data-label="Email">
{{ invitation.domain_invitation.email }} {{ invitation.domain_invitation.email }}
{% if invitation.has_admin_flag %}<span class="usa-tag margin-left-1 bg-primary">Admin</span>{% endif %} {% if invitation.has_admin_flag %}<span class="usa-tag margin-left-1 bg-primary-dark text-semibold">Admin</span>{% endif %}
</th> </th>
<td data-sort-value="{{ invitation.domain_invitation.created_at|date:"U" }}" data-label="Date created">{{ invitation.domain_invitation.created_at|date }} </td> <td data-sort-value="{{ invitation.domain_invitation.created_at|date:"U" }}" data-label="Date created">{{ invitation.domain_invitation.created_at|date }} </td>
{% if not portfolio %}<td data-label="Status">{{ invitation.domain_invitation.status|title }}</td>{% endif %} {% if not portfolio %}<td data-label="Status">{{ invitation.domain_invitation.status|title }}</td>{% endif %}

2
src/registrar/templates/includes/form_messages.html
View file

@ -1,7 +1,7 @@
{% if messages %} {% if messages %}
{% for message in messages %} {% for message in messages %}
<div class="usa-alert usa-alert--{{ message.tags }} usa-alert--slim margin-bottom-2"> <div class="usa-alert usa-alert--{{ message.tags }} usa-alert--slim margin-bottom-2">
<div class="usa-alert__body"> <div class="usa-alert__body {% if no_max_width %} maxw-none {% endif %}">
{{ message }} {{ message }}
</div> </div>
</div> </div>

10
src/registrar/templates/includes/member_domains_edit_table.html
View file

@ -23,7 +23,7 @@
{% comment %} Stores the json endpoint in a url for easier access {% endcomment %} {% comment %} Stores the json endpoint in a url for easier access {% endcomment %}
{% url 'get_member_domains_json' as url %} {% url 'get_member_domains_json' as url %}
<span id="get_member_domains_json_url" class="display-none">{{url}}</span> <span id="get_member_domains_json_url" class="display-none">{{url}}</span>
<section class="section-outlined member-domains margin-top-0 section-outlined--border-base-light" id="edit-member-domains"> <section class="section-outlined member-domains margin-top-0 padding-bottom-0 section-outlined--border-base-light" id="edit-member-domains">
<h2> <h2>
Edit domains assigned to Edit domains assigned to
@ -37,7 +37,7 @@
<div class="section-outlined__header margin-bottom-3 grid-row"> <div class="section-outlined__header margin-bottom-3 grid-row">
<!-- ---------- SEARCH ---------- --> <!-- ---------- SEARCH ---------- -->
<div class="section-outlined__search mobile:grid-col-12 desktop:grid-col-9"> <div class="section-outlined__search mobile:grid-col-12 desktop:grid-col-9">
<section aria-label="Member domains search component" class="margin-top-2"> <section aria-label="Member domains search component">
<form class="usa-search usa-search--show-label" method="POST" role="search"> <form class="usa-search usa-search--show-label" method="POST" role="search">
{% csrf_token %} {% csrf_token %}
<label class="usa-label display-block margin-bottom-05" for="edit-member-domains__search-field"> <label class="usa-label display-block margin-bottom-05" for="edit-member-domains__search-field">
@ -81,7 +81,7 @@
<!-- ---------- MAIN TABLE ---------- --> <!-- ---------- MAIN TABLE ---------- -->
<div class="display-none margin-top-0" id="edit-member-domains__table-wrapper"> <div class="display-none margin-top-0" id="edit-member-domains__table-wrapper">
<table class="usa-table usa-table--borderless usa-table--stacked dotgov-table dotgov-table--stacked"> <table class="usa-table usa-table--borderless usa-table--stacked dotgov-table dotgov-table--stacked margin-bottom-4">
<caption class="sr-only">member domains</caption> <caption class="sr-only">member domains</caption>
<thead> <thead>
<tr> <tr>
@ -99,10 +99,10 @@
aria-live="polite" aria-live="polite"
></div> ></div>
</div> </div>
<div class="display-none" id="edit-member-domains__no-data"> <div class="display-none margin-bottom-4" id="edit-member-domains__no-data">
<p>This member does not manage any domains. Click the Edit domain assignments buttons to assign domains.</p> <p>This member does not manage any domains. Click the Edit domain assignments buttons to assign domains.</p>
</div> </div>
<div class="display-none" id="edit-member-domains__no-search-results"> <div class="display-none margin-bottom-4" id="edit-member-domains__no-search-results">
<p>No results found</p> <p>No results found</p>
</div> </div>
</section> </section>

10
src/registrar/templates/includes/member_domains_table.html
View file

@ -23,7 +23,7 @@
{% comment %} Stores the json endpoint in a url for easier access {% endcomment %} {% comment %} Stores the json endpoint in a url for easier access {% endcomment %}
{% url 'get_member_domains_json' as url %} {% url 'get_member_domains_json' as url %}
<span id="get_member_domains_json_url" class="display-none">{{url}}</span> <span id="get_member_domains_json_url" class="display-none">{{url}}</span>
<section class="section-outlined member-domains margin-top-0 section-outlined--border-base-light" id="member-domains"> <section class="section-outlined member-domains margin-top-0 padding-bottom-0 section-outlined--border-base-light" id="member-domains">
<h2> <h2>
Domains assigned to Domains assigned to
@ -37,7 +37,7 @@
<div class="section-outlined__header margin-bottom-3 grid-row" id="edit-member-domains__search"> <div class="section-outlined__header margin-bottom-3 grid-row" id="edit-member-domains__search">
<!-- ---------- SEARCH ---------- --> <!-- ---------- SEARCH ---------- -->
<div class="section-outlined__search mobile:grid-col-12 desktop:grid-col-9"> <div class="section-outlined__search mobile:grid-col-12 desktop:grid-col-9">
<section aria-label="Member domains search component" class="margin-top-2"> <section aria-label="Member domains search component">
<form class="usa-search usa-search--show-label" method="POST" role="search"> <form class="usa-search usa-search--show-label" method="POST" role="search">
{% csrf_token %} {% csrf_token %}
<label class="usa-label display-block margin-bottom-05" for="member-domains__search-field"> <label class="usa-label display-block margin-bottom-05" for="member-domains__search-field">
@ -77,7 +77,7 @@
<!-- ---------- MAIN TABLE ---------- --> <!-- ---------- MAIN TABLE ---------- -->
<div class="display-none margin-top-0" id="member-domains__table-wrapper"> <div class="display-none margin-top-0" id="member-domains__table-wrapper">
<table class="usa-table usa-table--borderless usa-table--stacked dotgov-table dotgov-table--stacked"> <table class="usa-table usa-table--borderless usa-table--stacked dotgov-table dotgov-table--stacked margin-bottom-4">
<caption class="sr-only">member domains</caption> <caption class="sr-only">member domains</caption>
<thead> <thead>
<tr> <tr>
@ -94,10 +94,10 @@
aria-live="polite" aria-live="polite"
></div> ></div>
</div> </div>
<div class="display-none" id="member-domains__no-data"> <div class="display-none margin-bottom-4" id="member-domains__no-data">
<p>This member does not manage any domains. Click the Edit domain assignments buttons to assign domains.</p> <p>This member does not manage any domains. Click the Edit domain assignments buttons to assign domains.</p>
</div> </div>
<div class="display-none" id="member-domains__no-search-results"> <div class="display-none margin-bottom-4" id="member-domains__no-search-results">
<p>No results found</p> <p>No results found</p>
</div> </div>
</section> </section>

2
src/registrar/templates/includes/members_table.html
View file

@ -54,7 +54,7 @@
<thead> <thead>
<tr> <tr>
<th data-sortable="member" role="columnheader" id="header-member">Member</th> <th data-sortable="member" role="columnheader" id="header-member">Member</th>
<th data-sortable="last_active" role="columnheader" id="header-last-active">Last Active</th> <th data-sortable="last_active" role="columnheader" id="header-last-active">Last active</th>
<th <th
role="columnheader" role="columnheader"
id="header-action" id="header-action"

4
src/registrar/templates/portfolio_member.html
View file

@ -16,7 +16,7 @@ Organization member
{% endblock messages%} {% endblock messages%}
{% url 'members' as url %} {% url 'members' as url %}
<nav class="usa-breadcrumb padding-top-0 margin-bottom-3" aria-label="Portfolio member breadcrumb"> <nav class="usa-breadcrumb padding-top-0" aria-label="Portfolio member breadcrumb">
<ol class="usa-breadcrumb__list"> <ol class="usa-breadcrumb__list">
<li class="usa-breadcrumb__list-item"> <li class="usa-breadcrumb__list-item">
<a href="{{ url }}" class="usa-breadcrumb__link"><span>Members</span></a> <a href="{{ url }}" class="usa-breadcrumb__link"><span>Members</span></a>
@ -41,7 +41,7 @@ Organization member
{% if has_edit_members_portfolio_permission %} {% if has_edit_members_portfolio_permission %}
{% if member %} {% if member %}
<div id="wrapper-delete-action" <div id="wrapper-delete-action"
data-member-name="{{ member.email }}" data-member-name="{{ member.get_formatted_name }}"
data-member-type="member" data-member-type="member"
data-member-id="{{ member.id }}" data-member-id="{{ member.id }}"
data-num-domains="{{ portfolio_permission.get_managed_domains_count }}" data-num-domains="{{ portfolio_permission.get_managed_domains_count }}"

6
src/registrar/templates/portfolio_member_domains.html
View file

@ -21,7 +21,7 @@
{% url 'invitedmember' pk=portfolio_invitation.id as url2 %} {% url 'invitedmember' pk=portfolio_invitation.id as url2 %}
{% url 'invitedmember-domains-edit' pk=portfolio_invitation.id as url3 %} {% url 'invitedmember-domains-edit' pk=portfolio_invitation.id as url3 %}
{% endif %} {% endif %}
<nav class="usa-breadcrumb padding-top-0 margin-bottom-3" aria-label="Portfolio member breadcrumb"> <nav class="usa-breadcrumb padding-top-0" aria-label="Portfolio member breadcrumb">
<ol class="usa-breadcrumb__list"> <ol class="usa-breadcrumb__list">
<li class="usa-breadcrumb__list-item"> <li class="usa-breadcrumb__list-item">
<a href="{{ url }}" class="usa-breadcrumb__link"><span>Members</span></a> <a href="{{ url }}" class="usa-breadcrumb__link"><span>Members</span></a>
@ -37,7 +37,7 @@
<div class="grid-row grid-gap"> <div class="grid-row grid-gap">
<div class="mobile:grid-col-12 tablet:grid-col-7"> <div class="mobile:grid-col-12 tablet:grid-col-7">
<h1 class="margin-bottom-3">Domain assignments</h1> <h1>Domain assignments</h1>
</div> </div>
{% if has_edit_members_portfolio_permission %} {% if has_edit_members_portfolio_permission %}
<div class="mobile:grid-col-12 tablet:grid-col-5"> <div class="mobile:grid-col-12 tablet:grid-col-5">
@ -51,7 +51,7 @@
{% endif %} {% endif %}
</div> </div>
<p> <p class="margin-top-0 margin-bottom-4 maxw-none">
A domain manager can be assigned to any domain across the organization. Domain managers can change domain information, adjust DNS settings, and invite or assign other domain managers to their assigned domains. A domain manager can be assigned to any domain across the organization. Domain managers can change domain information, adjust DNS settings, and invite or assign other domain managers to their assigned domains.
</p> </p>

20
src/registrar/templates/portfolio_member_domains_edit.html
View file

@ -21,7 +21,7 @@
{% url 'invitedmember' pk=portfolio_invitation.id as url2 %} {% url 'invitedmember' pk=portfolio_invitation.id as url2 %}
{% url 'invitedmember-domains' pk=portfolio_invitation.id as url3 %} {% url 'invitedmember-domains' pk=portfolio_invitation.id as url3 %}
{% endif %} {% endif %}
<nav class="usa-breadcrumb padding-top-0 margin-bottom-3" aria-label="Portfolio member breadcrumb"> <nav class="usa-breadcrumb padding-top-0" aria-label="Portfolio member breadcrumb">
<ol class="usa-breadcrumb__list"> <ol class="usa-breadcrumb__list">
<li class="usa-breadcrumb__list-item"> <li class="usa-breadcrumb__list-item">
<a href="{{ url }}" class="usa-breadcrumb__link"><span>Members</span></a> <a href="{{ url }}" class="usa-breadcrumb__link"><span>Members</span></a>
@ -39,12 +39,10 @@
</nav> </nav>
<section id="domain-assignments-edit-view"> <section id="domain-assignments-edit-view">
<h1 class="margin-bottom-3">Edit domain assignments</h1> <h1>Edit domain assignments</h1>
<p class="margin-bottom-0"> <p class="margin-top-0 margin-bottom-4 maxw-none">
A domain manager can be assigned to any domain across the organization. Domain managers can change domain information, adjust DNS settings, and invite or assign other domain managers to their assigned domains. A domain manager can be assigned to any domain across the organization. Domain managers can change domain information, adjust DNS settings, and invite or assign other domain managers to their assigned domains.
</p>
<p>
When you save this form the member will get an email to notify them of any changes. When you save this form the member will get an email to notify them of any changes.
</p> </p>
@ -76,7 +74,7 @@
<section id="domain-assignments-readonly-view" class="display-none"> <section id="domain-assignments-readonly-view" class="display-none">
<h1 class="margin-bottom-3">Review domain assignments</h1> <h1 class="margin-bottom-3">Review domain assignments</h1>
<h2>Would you like to continue with the following domain assignment changes for <h2 class="margin-top-0">Would you like to continue with the following domain assignment changes for
{% if member %} {% if member %}
{{ member.email }} {{ member.email }}
{% else %} {% else %}
@ -84,17 +82,19 @@
{% endif %} {% endif %}
</h2> </h2>
<p>When you save this form the member will get an email to notify them of any changes.</p> <p class="margin-bottom-4">
When you save this form the member will get an email to notify them of any changes.
</p>
<div id="domain-assignments-summary" class="margin-bottom-2"> <div id="domain-assignments-summary" class="margin-bottom-5">
<!-- AJAX will populate this summary --> <!-- AJAX will populate this summary -->
<h3 class="margin-bottom-1">Unassigned domains</h3> <h3 class="margin-bottom-1 h4">Unassigned domains</h3>
<ul class="usa-list usa-list--unstyled"> <ul class="usa-list usa-list--unstyled">
<li>item1</li> <li>item1</li>
<li>item2</li> <li>item2</li>
</ul> </ul>
<h3 class="margin-bottom-0">Assigned domains</h3> <h3 class="margin-bottom-0 h4">Assigned domains</h3>
<ul class="usa-list usa-list--unstyled"> <ul class="usa-list usa-list--unstyled">
<li>item1</li> <li>item1</li>
<li>item2</li> <li>item2</li>

4
src/registrar/templates/portfolio_members.html
View file

@ -12,12 +12,12 @@
<!-- Form messages --> <!-- Form messages -->
{% block messages %} {% block messages %}
{% include "includes/form_messages.html" %} {% include "includes/form_messages.html" with no_max_width=True %}
{% endblock messages%} {% endblock messages%}
<div id="main-content"> <div id="main-content">
<div id="toggleable-alert" class="usa-alert usa-alert--slim margin-bottom-2 display-none"> <div id="toggleable-alert" class="usa-alert usa-alert--slim margin-bottom-2 display-none">
<div class="usa-alert__body usa-alert__body--widescreen"> <div class="usa-alert__body">
<p class="usa-alert__text "> <p class="usa-alert__text ">
<!-- alert message will be conditionally populated by javascript --> <!-- alert message will be conditionally populated by javascript -->
</p> </p>

75
src/registrar/tests/test_management_scripts.py
View file

@ -35,7 +35,13 @@ import tablib
from unittest.mock import patch, call, MagicMock, mock_open from unittest.mock import patch, call, MagicMock, mock_open
from epplibwrapper import commands, common from epplibwrapper import commands, common
from .common import MockEppLib, less_console_noise, completed_domain_request, MockSESClient, MockDbForIndividualTests from .common import (
MockEppLib,
less_console_noise,
completed_domain_request,
MockSESClient,
MockDbForIndividualTests,
)
from api.tests.common import less_console_noise_decorator from api.tests.common import less_console_noise_decorator
@ -1825,7 +1831,7 @@ class TestCreateFederalPortfolio(TestCase):
self.run_create_federal_portfolio(agency_name="Non-existent Agency", parse_requests=True) self.run_create_federal_portfolio(agency_name="Non-existent Agency", parse_requests=True)
def test_does_not_update_existing_portfolio(self): def test_does_not_update_existing_portfolio(self):
"""Tests that an existing portfolio is not updated""" """Tests that an existing portfolio is not updated when"""
# Create an existing portfolio # Create an existing portfolio
existing_portfolio = Portfolio.objects.create( existing_portfolio = Portfolio.objects.create(
federal_agency=self.federal_agency, federal_agency=self.federal_agency,
@ -1848,6 +1854,71 @@ class TestCreateFederalPortfolio(TestCase):
self.assertEqual(existing_portfolio.notes, "Old notes") self.assertEqual(existing_portfolio.notes, "Old notes")
self.assertEqual(existing_portfolio.creator, self.user) self.assertEqual(existing_portfolio.creator, self.user)
def test_skip_existing_portfolios(self):
"""Tests the skip_existing_portfolios to ensure that it doesn't add
suborgs, domain requests, and domain info."""
# Create an existing portfolio with a suborganization
existing_portfolio = Portfolio.objects.create(
federal_agency=self.federal_agency,
organization_name="Test Federal Agency",
organization_type=DomainRequest.OrganizationChoices.CITY,
creator=self.user,
notes="Old notes",
)
existing_suborg = Suborganization.objects.create(
portfolio=existing_portfolio, name="Existing Suborg", city="Old City", state_territory="CA"
)
# Create a domain request that would normally be associated
domain_request = completed_domain_request(
name="wackytaco.gov",
status=DomainRequest.DomainRequestStatus.IN_REVIEW,
generic_org_type=DomainRequest.OrganizationChoices.FEDERAL,
federal_agency=self.federal_agency,
user=self.user,
organization_name="would_create_suborg",
)
domain_request.approve()
domain = Domain.objects.get(name="wackytaco.gov").domain_info
# Run the command with skip_existing_portfolios=True
self.run_create_federal_portfolio(
agency_name="Test Federal Agency", parse_requests=True, skip_existing_portfolios=True
)
# Refresh objects from database
existing_portfolio.refresh_from_db()
existing_suborg.refresh_from_db()
domain_request.refresh_from_db()
domain.refresh_from_db()
# Verify nothing was changed on the portfolio itself
# SANITY CHECK: if the portfolio updates, it will change to FEDERAL.
# if this case fails, it means we are overriding data (and not simply just other weirdness)
self.assertNotEqual(existing_portfolio.organization_type, DomainRequest.OrganizationChoices.FEDERAL)
# Notes and creator should be untouched
self.assertEqual(existing_portfolio.organization_type, DomainRequest.OrganizationChoices.CITY)
self.assertEqual(existing_portfolio.organization_name, self.federal_agency.agency)
self.assertEqual(existing_portfolio.notes, "Old notes")
self.assertEqual(existing_portfolio.creator, self.user)
# Verify suborganization wasn't modified
self.assertEqual(existing_suborg.city, "Old City")
self.assertEqual(existing_suborg.state_territory, "CA")
# Verify that the domain request wasn't modified
self.assertIsNone(domain_request.portfolio)
self.assertIsNone(domain_request.sub_organization)
# Verify that the domain wasn't modified
self.assertIsNone(domain.portfolio)
self.assertIsNone(domain.sub_organization)
# Verify that a new suborg wasn't created
self.assertFalse(Suborganization.objects.filter(name="would_create_suborg").exists())
@less_console_noise_decorator @less_console_noise_decorator
def test_post_process_suborganization_fields(self): def test_post_process_suborganization_fields(self):
"""Test suborganization field updates from domain and request data. """Test suborganization field updates from domain and request data.

17
src/registrar/tests/test_views_portfolio.py
View file

@ -1468,7 +1468,9 @@ class TestPortfolio(WebTest):
# Create a member under same portfolio # Create a member under same portfolio
member_email = "a_member@example.com" member_email = "a_member@example.com"
member, _ = User.objects.get_or_create(username="a_member", email=member_email) member, _ = User.objects.get_or_create(
username="a_member", email=member_email, first_name="First", last_name="Last"
)
upp, _ = UserPortfolioPermission.objects.get_or_create( upp, _ = UserPortfolioPermission.objects.get_or_create(
user=member, user=member,
@ -1485,7 +1487,8 @@ class TestPortfolio(WebTest):
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 200)
# Check for email AND member type (which here is just member) # Check for email AND member type (which here is just member)
self.assertContains(response, f'data-member-name="{member_email}"') self.assertContains(response, f'data-member-email="{member_email}"')
self.assertContains(response, 'data-member-name="First Last"')
self.assertContains(response, 'data-member-type="member"') self.assertContains(response, 'data-member-type="member"')
@less_console_noise_decorator @less_console_noise_decorator
@ -1676,8 +1679,9 @@ class TestPortfolio(WebTest):
self.assertEqual(response.status_code, 400) # Bad request due to active requests self.assertEqual(response.status_code, 400) # Bad request due to active requests
support_url = "https://get.gov/contact/" support_url = "https://get.gov/contact/"
expected_error_message = ( expected_error_message = (
f"This member has an active domain request and can't be removed from the organization. " "This member can't be removed from the organization because they have an active domain request. "
f"<a href='{support_url}' target='_blank'>Contact the .gov team</a> to remove them." f"Please <a class='usa-link' href='{support_url}' target='_blank'>contact us</a> "
"to remove this member."
) )
self.assertContains(response, expected_error_message, status_code=400) self.assertContains(response, expected_error_message, status_code=400)
@ -1799,8 +1803,9 @@ class TestPortfolio(WebTest):
support_url = "https://get.gov/contact/" support_url = "https://get.gov/contact/"
expected_error_message = ( expected_error_message = (
f"This member has an active domain request and can't be removed from the organization. " "This member can't be removed from the organization because they have an active domain request. "
f"<a href='{support_url}' target='_blank'>Contact the .gov team</a> to remove them." f"Please <a class='usa-link' href='{support_url}' target='_blank'>contact us</a> "
"to remove this member."
) )
args, kwargs = mock_error.call_args args, kwargs = mock_error.call_args

4
src/registrar/views/portfolios.py
View file

@ -118,8 +118,8 @@ class PortfolioMemberDeleteView(PortfolioMemberPermission, View):
if active_requests_count > 0: if active_requests_count > 0:
# If they have any in progress requests # If they have any in progress requests
error_message = mark_safe( # nosec error_message = mark_safe( # nosec
f"This member has an active domain request and can't be removed from the organization. " "This member can't be removed from the organization because they have an active domain request. "
f"<a href='{support_url}' target='_blank'>Contact the .gov team</a> to remove them." f"Please <a class='usa-link' href='{support_url}' target='_blank'>contact us</a> to remove this member."
) )
elif member.is_only_admin_of_portfolio(portfolio_member_permission.portfolio): elif member.is_only_admin_of_portfolio(portfolio_member_permission.portfolio):
# If they are the last manager of a domain # If they are the last manager of a domain