zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-15 17:17:02 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix test cases

Browse source
This commit is contained in:
zandercymatics 2023-12-14 09:29:18 -07:00
parent 3d4972773c
commit daf640ded3
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 15 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/registrar/admin.py
View file

@ -551,6 +551,7 @@ class DomainApplicationAdmin(ListHeaderAdmin):
class InvestigatorFilter(admin.SimpleListFilter):
"""Custom investigator filter that only displays users with the manager role"""
title = "investigator"
parameter_name = "investigator"

50
src/registrar/tests/test_admin.py
View file

@ -856,62 +856,38 @@ class TestDomainApplicationAdmin(MockEppLib):
def test_displays_investigator_filter(self):
"""Tests if DomainApplicationAdmin displays the investigator filter"""
# Create a mock DomainApplication object, with a fake investigator
application: DomainApplication = generic_domain_object("application", "SomeGuy")
investigator_user = User.objects.filter(username=application.investigator.username).get()
investigator_user.is_staff = True
investigator_user.save()
p = "userpass"
self.client.login(username="staffuser", password=p)
response = self.client.get(
"/admin/registrar/domainapplication/",
{
"investigator": investigator_user.id,
},
follow=True,
)
# Create a mock DomainApplication object, with a fake investigator
application: DomainApplication = generic_domain_object("application", "SomeGuy")
# Add the role manager to the investigator
UserDomainRole.objects.get_or_create(
user=application.investigator,
role=UserDomainRole.Roles.MANAGER,
domain=Domain.objects.create(name="SomeGuy.gov")
)
# First, make sure that there is still an investigator field to begin with
expected_sort_column = "sortable column-investigator"
self.assertContains(response, expected_sort_column, count=1)
# Then, test if the filter actually exists
self.assertIn("filters", response.context)
# Assert the content of filters and search_query
filters = response.context["filters"]
print(response.context.__dict__)
self.assertEqual(
filters,
[
{"parameter_name": "status", "parameter_value": "started"},
{
"parameter_name": "investigator",
"parameter_value": "test",
"parameter_value": "4",
},
],
)
def test_investigator_filter(self):
"""Tests the custom investigator filter"""
# Creates multiple domain applications
multiple_unalphabetical_domain_objects("application")
p = "userpass"
self.client.login(username="staffuser", password=p)
response = self.client.get(
"/admin/registrar/domainapplication/",
{
"investigator": 1,
},
follow=True,
)
# The "multiple_unalphabetical_domain_objects" function will create
# user objects with a first name that contains "first_name:investigator".
# We can simply count how many times this appears in the table to determine
# how many records exist.
self.assertContains(response, "first_name:investigator", count=1)
def tearDown(self):
super().tearDown()
Domain.objects.all().delete()