updates & fixes

src/registrar/management/commands/load_transition_domain.py

@@ -66,6 +66,8 @@ class Command(BaseCommand):
         )
 
         # TODO - Narrow this down
+        # TODO - this isn't pulling in the directory from the master script.  Needs to be corrected @Nicolle - todo
+        # default="/app/tmp"
         parser.add_argument(
             "--directory", default="migrationdata", help="Desired directory"
         )
@@ -291,8 +293,9 @@ class Command(BaseCommand):
             # Update every TransitionDomain object where applicable
             extra_data.update_transition_domain_models()
         except Exception as err:
-            logger.error("Could not load additional TransitionDomain data.")
+            logger.error(f"Could not load additional TransitionDomain data. {err}")
             raise err
+            # TODO: handle this better...needs more logging
 
     def handle(  # noqa: C901
         self,
@@ -540,7 +543,7 @@ class Command(BaseCommand):
         # Prompt the user if they want to load additional data on the domains
         title = "Do you wish to load additional data for TransitionDomains?"
         do_parse_extra = TerminalHelper.prompt_for_execution(
-            system_exit_on_terminate=True,
+            system_exit_on_terminate=False,
             info_to_inspect=f"""
             !!! ENSURE THAT ALL FILENAMES ARE CORRECT BEFORE PROCEEDING
             ==Federal agency information==

src/registrar/management/commands/master_domain_migrations.py

@@ -28,8 +28,12 @@ logger = logging.getLogger(__name__)
 
 
 class Command(BaseCommand):
-    help = """ """
+    help = """ """ # TODO: update this!
 
+
+    # ======================================================
+    # ==================    ARGUMENTS    ===================
+    # ======================================================
     def add_arguments(self, parser):
         """
         OPTIONAL ARGUMENTS:
@@ -134,6 +138,11 @@ class Command(BaseCommand):
             action=argparse.BooleanOptionalAction,
         )
 
+
+    # ======================================================
+    # ===============    DATA ANALYSIS    ==================
+    # ======================================================
+
     def compare_tables(self, debug_on: bool):
         """Does a diff between the transition_domain and the following tables:
         domain, domain_information and the domain_invitation.
@@ -252,6 +261,10 @@ class Command(BaseCommand):
             """
         )
 
+
+    # ======================================================
+    # =================    MIGRATIONS    ===================
+    # ======================================================
     def run_load_transition_domain_script(
         self,
         file_location: str,

src/registrar/management/commands/utility/terminal_helper.py

@@ -70,6 +70,13 @@ class TerminalHelper:
             else:
                 logger.info("Please respond with 'yes' or 'no' " "(or 'y' or 'n').\n")
 
+    # @staticmethod
+    # def array_as_string(array_to_convert: []) -> str:
+    #     array_as_string = "{}".format(
+    #         ", ".join(map(str, array_to_convert))
+    #     )
+    #     return array_as_string
+
     @staticmethod
     def print_conditional(
         print_condition: bool,