zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-16 09:37:03 +02:00
Code Issues Projects Releases Packages Wiki Activity

Update comments

Browse source
This commit is contained in:
Rebecca Hsieh 2024-02-12 17:46:24 -08:00
parent 8ea135b5a4
commit d329ae6c8f
No known key found for this signature in database
2 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/registrar/templates/home.html
View file

@ -13,7 +13,7 @@
{% block messages %} {% block messages %}
{% include "includes/form_messages.html" %} {% include "includes/form_messages.html" %}
{% endblock %} {% endblock %}
<h1>Manage your domains - TEST TEST 123</h2> <h1>Manage your domains</h2>
<p class="margin-top-4"> <p class="margin-top-4">

15
src/registrar/utility/csv_export.py
View file

@ -97,7 +97,7 @@ def parse_row(columns, domain_info: DomainInformation, security_emails_dict=None
# Get each domain managers email and add to list # Get each domain managers email and add to list
dm_emails = [dm.user.email for dm in domain.permissions.all()] dm_emails = [dm.user.email for dm in domain.permissions.all()]
# This is the row fields # Set up the "matching header" + row field data
for i, dm_email in enumerate(dm_emails, start=1): for i, dm_email in enumerate(dm_emails, start=1):
FIELDS[f"Domain manager email {i}"] = dm_email FIELDS[f"Domain manager email {i}"] = dm_email
@ -129,7 +129,7 @@ def _get_security_emails(sec_contact_ids):
def update_columns_with_domain_managers(columns, max_dm_count): def update_columns_with_domain_managers(columns, max_dm_count):
""" """
Update the columns list to include "Domain manager email" headers Update the columns list to include "Domain manager email {#}" headers
based on the maximum domain manager count. based on the maximum domain manager count.
""" """
for i in range(1, max_dm_count + 1): for i in range(1, max_dm_count + 1):
@ -148,13 +148,10 @@ def write_body(
""" """
Receives params from the parent methods and outputs a CSV with fltered and sorted domains. Receives params from the parent methods and outputs a CSV with fltered and sorted domains.
Works with write_header as longas the same writer object is passed. Works with write_header as longas the same writer object is passed.
get_domain_managers: Conditional bc we only use domain manager info for export_data_full_to_csv
should_write_header: Conditional bc export_data_growth_to_csv calls write_body twice
""" """
# We only want to write the domain manager information for export_thing_here so we have to make it conditional
# Trying to make the domain managers logic conditional
# Get the domainInfos
all_domain_infos = get_domain_infos(filter_condition, sort_fields) all_domain_infos = get_domain_infos(filter_condition, sort_fields)
# Store all security emails to avoid epp calls or excessive filters # Store all security emails to avoid epp calls or excessive filters
@ -163,8 +160,9 @@ def write_body(
security_emails_dict = _get_security_emails(sec_contact_ids) security_emails_dict = _get_security_emails(sec_contact_ids)
# The maximum amount of domain managers an account has # The maximum amount of domain managers an account has
max_dm_count = 0
# We get the max so we can set the column header accurately # We get the max so we can set the column header accurately
max_dm_count = 0
# Flag bc we don't want to set header every loop
paginator_ran = False paginator_ran = False
# Reduce the memory overhead when performing the write operation # Reduce the memory overhead when performing the write operation
paginator = Paginator(all_domain_infos, 1000) paginator = Paginator(all_domain_infos, 1000)
@ -185,7 +183,6 @@ def write_body(
# It indicates that DomainInformation.domain is None. # It indicates that DomainInformation.domain is None.
logger.error("csv_export -> Error when parsing row, domain was None") logger.error("csv_export -> Error when parsing row, domain was None")
continue continue
# We only want this to run once just for the column header
if paginator_ran is False and should_write_header: if paginator_ran is False and should_write_header:
write_header(writer, columns) write_header(writer, columns)