zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-21 10:16:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

3743: Remove OMB analysts permissions to put domains on hold [AG] (#3768)

Browse source 
* Update omb analyst perms on admin
This commit is contained in:
Erin Song 2025-05-02 15:14:13 -07:00 • committed by GitHub
parent bd8b2a5a25
commit d1c989fb66
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 35 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/registrar/templates/django/admin/domain_change_form.html
View file

@ -9,17 +9,18 @@
{% endblock content %} {% endblock content %}
{% block field_sets %} {% block field_sets %}
<div class="display-flex flex-row flex-justify submit-row">
<div class="flex-align-self-start button-list-mobile">
{% if not adminform.form.is_omb_analyst %} {% if not adminform.form.is_omb_analyst %}
<div class="display-flex flex-row flex-justify submit-row">
<div class="flex-align-self-start button-list-mobile">
<input id="manageDomainSubmitButton" type="submit" value="Manage domain" name="_edit_domain"> <input id="manageDomainSubmitButton" type="submit" value="Manage domain" name="_edit_domain">
{# Dja has margin styles defined on inputs as is. Lets work with it, rather than fight it. #} {# Dja has margin styles defined on inputs as is. Lets work with it, rather than fight it. #}
<span class="mini-spacer"></span> <span class="mini-spacer"></span>
<input type="submit" value="Get registry status" name="_get_status"> <input type="submit" value="Get registry status" name="_get_status">
{% endif %}
</div> </div>
<div class="desktop:flex-align-self-end"> <div class="desktop:flex-align-self-end">
{% if original.state != original.State.DELETED and not adminform.form.is_omb_analyst %} {% if original.state != original.State.DELETED %}
<a class="text-middle" href="#toggle-extend-expiration-alert" aria-controls="toggle-extend-expiration-alert" data-open-modal> <a class="text-middle" href="#toggle-extend-expiration-alert" aria-controls="toggle-extend-expiration-alert" data-open-modal>
Extend expiration date Extend expiration date
</a> </a>
@ -33,17 +34,16 @@
<input type="submit" value="Remove hold" name="_remove_client_hold" class="custom-link-button"> <input type="submit" value="Remove hold" name="_remove_client_hold" class="custom-link-button">
{% endif %} {% endif %}
{% if original.state == original.State.READY or original.state == original.State.ON_HOLD %} {% if original.state == original.State.READY or original.state == original.State.ON_HOLD %}
{% if not adminform.form.is_omb_analyst %}
<span class="margin-left-05 margin-right-05 text-middle"> | </span> <span class="margin-left-05 margin-right-05 text-middle"> | </span>
{% endif %} {% endif %}
{% endif %} {% if original.state != original.State.DELETED %}
{% if original.state != original.State.DELETED and not adminform.form.is_omb_analyst %}
<a class="text-middle" href="#toggle-remove-from-registry" aria-controls="toggle-remove-from-registry" data-open-modal> <a class="text-middle" href="#toggle-remove-from-registry" aria-controls="toggle-remove-from-registry" data-open-modal>
Remove from registry Remove from registry
</a> </a>
{% endif %} {% endif %}
</div> </div>
</div> </div>
{% endif %}
{% for fieldset in adminform %} {% for fieldset in adminform %}
{% include "django/admin/includes/domain_fieldset.html" with state_help_message=state_help_message %} {% include "django/admin/includes/domain_fieldset.html" with state_help_message=state_help_message %}

2
src/registrar/tests/test_admin_domain.py
View file

@ -124,7 +124,7 @@ class TestDomainAdminAsStaff(MockEppLib):
self.assertNotContains(response, "Get registry status") self.assertNotContains(response, "Get registry status")
self.assertNotContains(response, "Extend expiration date") self.assertNotContains(response, "Extend expiration date")
self.assertNotContains(response, "Remove from registry") self.assertNotContains(response, "Remove from registry")
self.assertContains(response, "Place hold") self.assertNotContains(response, "Place hold")
self.assertContains(response, "Save") self.assertContains(response, "Save")
self.assertNotContains(response, ">Delete<") self.assertNotContains(response, ">Delete<")
# test whether fields are readonly or editable # test whether fields are readonly or editable