zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-17 18:09:25 +02:00
Code Issues Projects Releases Packages Wiki Activity

cleanup

Browse source
This commit is contained in:
zandercymatics 2024-09-30 12:33:08 -06:00
parent 7a5eda065b
commit cfa1879909
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/registrar/assets/js/get-gov-admin.js
View file

@ -644,9 +644,9 @@ class customActionNeededEmail extends CustomizableEmailBase {
}
loadActionNeededEmail() {
if (this.textAreaFormGroup && this.dropdownFormGroup) {
this.initializeFormGroups("action needed", "showActionNeededReason");
}
// Hide/show the email fields depending on the current status
this.initializeFormGroups("action needed", "showActionNeededReason");
// Setup the textarea, edit button, helper text
this.updateUserInterface(this.dropdown.value);
this.initializeDropdown("Error when attempting to grab action needed email: ")
this.initializeModalConfirm()
@ -713,10 +713,7 @@ class customRejectedEmail extends CustomizableEmailBase {
}
loadRejectedEmail() {
if (this.textAreaFormGroup && this.dropdownFormGroup) {
// TODO: fix this for rejected
this.initializeFormGroups("rejected", "showRejectionReason");
}
this.initializeFormGroups("rejected", "showRejectionReason");
this.updateUserInterface(this.dropdown.value);
this.initializeDropdown("Error when attempting to grab rejected email: ")
this.initializeModalConfirm()

2
src/registrar/models/domain_request.py
View file

@ -693,7 +693,7 @@ class DomainRequest(TimeStampedModel):
# We should never send an email if no reason was specified
# Additionally, Don't send out emails for reasons that shouldn't send them
if new_reason is None or self.action_needed_reason in excluded_reasons:
if new_reason is None or new_reason in excluded_reasons:
return
# Only send out an email if the underlying email itself changed