diff --git a/src/registrar/tests/test_views_members_json.py b/src/registrar/tests/test_views_members_json.py index d7b9f3a9f..5555c94c1 100644 --- a/src/registrar/tests/test_views_members_json.py +++ b/src/registrar/tests/test_views_members_json.py @@ -157,7 +157,7 @@ class GetPortfolioMembersJsonTest(MockEppLib, WebTest): @override_flag("organization_members", active=True) def test_get_portfolio_invited_json_authenticated(self): """Test that portfolio invitees are returned properly for an authenticated user.""" - """Also tests that reposnse is 200 when no domains""" + """Also tests that response is 200 when no domains""" UserPortfolioPermission.objects.create( user=self.user, portfolio=self.portfolio, @@ -318,19 +318,33 @@ class GetPortfolioMembersJsonTest(MockEppLib, WebTest): domain=domain, ) - # create a domain not in the portfolio + # create another domain in the portfolio domain2 = Domain.objects.create( - name="somedomain2.com", + name="thissecondinvitetestsasubqueryinjson@lets.notbreak", ) DomainInformation.objects.create( creator=self.user, domain=domain2, + portfolio=self.portfolio, ) DomainInvitation.objects.create( email=self.email6, domain=domain2, ) + # create a domain not in the portfolio + domain3 = Domain.objects.create( + name="somedomain2.com", + ) + DomainInformation.objects.create( + creator=self.user, + domain=domain3, + ) + DomainInvitation.objects.create( + email=self.email6, + domain=domain3, + ) + response = self.app.get(reverse("get_portfolio_members_json"), params={"portfolio": self.portfolio.id}) self.assertEqual(response.status_code, 200) data = response.json @@ -338,6 +352,7 @@ class GetPortfolioMembersJsonTest(MockEppLib, WebTest): # Check if the domain appears in the response JSON and domain2 does not domain_names = [domain_name for member in data["members"] for domain_name in member.get("domain_names", [])] self.assertIn("somedomain1.com", domain_names) + self.assertIn("thissecondinvitetestsasubqueryinjson@lets.notbreak", domain_names) self.assertNotIn("somedomain2.com", domain_names) @less_console_noise_decorator