zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-14 13:34:10 +02:00
Code Issues Projects Releases Packages Wiki Activity

Minor refactor fo update notification and formatting changes

Browse source
This commit is contained in:
Matthew Spence 2024-09-24 10:11:55 -05:00
parent 5dbc356d71
commit ccbefe209c
No known key found for this signature in database
2 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/registrar/templates/emails/update_to_approved_domain.txt
View file

@ -1,6 +1,8 @@
{% autoescape off %}{# In a text file, we don't want to have HTML entities escaped #}
Hi,
An update was made to a domain you manage.
DOMAIN: {{domain.gov}}
DOMAIN: {{domain}}
UPDATED BY: {{user}}
UPDATED ON: {{date}}
INFORMATION UPDATED: {{changes}}
@ -11,7 +13,7 @@ Get help with managing your .gov domain <https://get.gov/help/domain-management/
----------------------------------------------------------------
WHY DID YOU RECEIVE THIS EMAIL?
You’re listed as a domain manager for $domain.gov, so you’ll receive a notification whenever changes are made to that domain.
You’re listed as a domain manager for {{domain}}, so you’ll receive a notification whenever changes are made to that domain.
If you have questions or concerns, reach out to the person who made the change or reply to this email.
THANK YOU
@ -21,3 +23,4 @@ THANK YOU
The .gov team
Contact us <https://get.gov/contact/>
Learn about .gov <https://get.gov>
{% endautoescape %}

16
src/registrar/views/domain.py
View file

@ -149,11 +149,12 @@ class DomainFormBaseView(DomainBaseView, FormMixin):
return current_domain_info
def send_update_notification(self, form):
def send_update_notification(self, form, force_send=False):
"""Send a notification to all domain managers that an update has occured
for a single domain. Uses update_to_approved_domain.txt template.
Checks for changes, and does nothing if the form has not changed.
If there are no changes to the form, emails will NOT be sent unless force_send
is set to True.
"""
# send notification email for changes to any of these forms
@ -172,9 +173,10 @@ class DomainFormBaseView(DomainBaseView, FormMixin):
}
if form.__class__ in form_label_dict:
# these types of forms can cause notifications
should_notify=True
if form.__class__ in check_for_portfolio:
# check for portfolio
# some forms shouldn't cause notifications if they are in a portfolio
info = self.get_domain_info_from_domain()
if not info or info.portfolio:
should_notify = False
@ -182,7 +184,7 @@ class DomainFormBaseView(DomainBaseView, FormMixin):
# don't notify for any other types of forms
should_notify=False
if should_notify and form.has_changed:
if (should_notify and form.has_changed()) or force_send:
logger.info("Sending email to domain managers")
context={
@ -305,10 +307,10 @@ class DomainOrgNameAddressView(DomainFormBaseView):
def form_valid(self, form):
"""The form is valid, save the organization name and mailing address."""
form.save()
self.send_update_notification(form)
form.save()
messages.success(self.request, "The organization information for this domain has been updated.")
# superclass has the redirect
@ -602,7 +604,7 @@ class DomainDNSSECView(DomainFormBaseView):
logger.error(errmsg + ": " + err)
messages.error(self.request, errmsg)
else:
self.send_update_notification(form)
self.send_update_notification(form, force_send=True)
return self.form_valid(form)