zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-27 13:06:30 +02:00
Code Issues Projects Releases Packages Wiki Activity

simplify some things

Browse source
This commit is contained in:
matthewswspence 2025-02-06 14:17:52 -06:00
parent b4176e4f86
commit c969487bfc
No known key found for this signature in database
GPG key ID: FB458202A7852BA4
1 changed files with 15 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

46
src/registrar/management/commands/create_federal_portfolio.py
View file

@ -30,8 +30,8 @@ class Command(BaseCommand):
self.failed_portfolios = set() self.failed_portfolios = set()
self.added_managers = set() self.added_managers = set()
self.added_invitations = set() self.added_invitations = set()
self.skipped_invitations = set()
self.failed_managers = set() self.failed_managers = set()
self.failed_invitations = set()
def add_arguments(self, parser): def add_arguments(self, parser):
"""Add command line arguments to create federal portfolios. """Add command line arguments to create federal portfolios.
@ -162,8 +162,8 @@ class Command(BaseCommand):
TerminalHelper.log_script_run_summary( TerminalHelper.log_script_run_summary(
self.added_invitations, self.added_invitations,
self.failed_invitations, [],
[], # can't skip invitations, can only add or fail self.skipped_invitations,
log_header="----- INVITATIONS ADDED -----", log_header="----- INVITATIONS ADDED -----",
debug=False, debug=False,
display_as_str=True, display_as_str=True,
@ -237,45 +237,21 @@ class Command(BaseCommand):
def create_portfolio_invitation(self, portfolio: Portfolio, email: str): def create_portfolio_invitation(self, portfolio: Portfolio, email: str):
""" """
Create a portfolio invitation for the given user. Create a portfolio invitation for the given email.
If the user already has a portfolio invitation, retreive their invitation and create a portfolio permission.
""" """
try:
user = User.objects.get(email=email)
_, created = PortfolioInvitation.objects.get_or_create( _, created = PortfolioInvitation.objects.get_or_create(
portfolio=portfolio,
user=user,
defaults={"status": PortfolioInvitation.PortfolioInvitationStatus.INVITED},
)
if created:
logger.info(f"Created portfolio invitation for '{user}' to portfolio '{portfolio}'")
else:
logger.info(f"Retrieved existing portfolio invitation for '{user}' to portfolio '{portfolio}'")
# Assign portfolio permissions
_, created = UserPortfolioPermission.objects.get_or_create(
portfolio=portfolio,
user=user,
defaults={"role": UserPortfolioRoleChoices.ORGANIZATION_MEMBER},
)
if created:
logger.info(f"Created portfolio permission for '{user}' to portfolio '{portfolio}'")
else:
logger.info(f"Retrieved existing portfolio permission for '{user}' to portfolio '{portfolio}'")
self.added_invitations.add(user)
except User.DoesNotExist:
PortfolioInvitation.objects.get_or_create(
portfolio=portfolio, portfolio=portfolio,
email=email, email=email,
defaults={"status": PortfolioInvitation.PortfolioInvitationStatus.INVITED}, defaults={"status": PortfolioInvitation.PortfolioInvitationStatus.INVITED,
"roles": [UserPortfolioRoleChoices.ORGANIZATION_MEMBER]
},
) )
if created:
self.added_invitations.add(email) self.added_invitations.add(email)
logger.info(f"Created portfolio invitation for '{email}' to portfolio '{portfolio}'") logger.info(f"Created portfolio invitation for '{email}' to portfolio '{portfolio}'")
except Exception as exc: else:
self.failed_invitations.add(email) self.skipped_invitations.add(email)
logger.error(exc, exc_info=True) logger.info(f"Found existing portfolio invitation for '{email}' to portfolio '{portfolio}'")
logger.error(f"Failed to create portfolio invitation for '{email}' to portfolio '{portfolio}'")
def post_process_started_domain_requests(self, agencies, portfolios): def post_process_started_domain_requests(self, agencies, portfolios):
""" """