From c7ea0f8f33ff351a7ccbd28ac69f3960a032eb2d Mon Sep 17 00:00:00 2001 From: Rachid Mrad Date: Tue, 18 Feb 2025 17:03:52 -0500 Subject: [PATCH] Simplify form clean --- src/registrar/forms/portfolio.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/registrar/forms/portfolio.py b/src/registrar/forms/portfolio.py index 1bee4e236..36818b371 100644 --- a/src/registrar/forms/portfolio.py +++ b/src/registrar/forms/portfolio.py @@ -236,13 +236,6 @@ class BasePortfolioMemberForm(forms.ModelForm): if cleaned_data.get("member_permissions") == "no_access": cleaned_data["member_permissions"] = None - # Handle roles - # Ensure roles is a list but only if role is valid - if role: - cleaned_data["roles"] = [role] if isinstance(role, str) else role - else: - cleaned_data["roles"] = [] # Handle empty form case - # Handle additional_permissions valid_fields = self.ROLE_REQUIRED_FIELDS.get(role, []) additional_permissions = {cleaned_data.get(field) for field in valid_fields if cleaned_data.get(field)}