zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-12 20:49:41 +02:00
Code Issues Projects Releases Packages Wiki Activity

Let all linters run before failing

Browse source
This commit is contained in:
Seamus Johnston 2022-09-29 09:53:54 -05:00
parent 1de4debc3e
commit c7265285a8
No known key found for this signature in database
GPG key ID: 2F21225985069105
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/registrar/management/commands/lint.py
View file

@ -3,6 +3,10 @@ from subprocess import run, CalledProcessError # nosec
from django.core.management.base import BaseCommand, CommandError from django.core.management.base import BaseCommand, CommandError
class LinterError(Exception):
pass
class Command(BaseCommand): class Command(BaseCommand):
""" """
Helper command for running installed linters. Helper command for running installed linters.
@ -41,6 +45,7 @@ class Command(BaseCommand):
def handle(self, *args, **options): def handle(self, *args, **options):
try: try:
errors = []
for linter in self.linters.values(): for linter in self.linters.values():
self.stdout.write(f"[manage.py lint] {linter['purpose']}. . .") self.stdout.write(f"[manage.py lint] {linter['purpose']}. . .")
result = run(linter["args"]) result = run(linter["args"])
@ -51,12 +56,17 @@ class Command(BaseCommand):
f"{' '.join(linter['args'])}" f"{' '.join(linter['args'])}"
) )
) )
raise CalledProcessError(result.returncode, linter["args"]) errors.append(CalledProcessError(result.returncode, linter["args"]))
else: else:
self.stdout.write( self.stdout.write(
f"[manage.py lint] {linter['purpose']} completed with success!" f"[manage.py lint] {linter['purpose']} completed with success!"
) )
except CalledProcessError as e: if errors:
self.stdout.write(
f"[manage.py lint] {len(errors)} linter(s) failed."
)
raise LinterError(errors)
except (CalledProcessError, LinterError) as e:
raise CommandError(e) raise CommandError(e)
self.stdout.write( self.stdout.write(
self.style.SUCCESS("[manage.py lint] All linters ran successfully.") self.style.SUCCESS("[manage.py lint] All linters ran successfully.")