zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-29 05:56:30 +02:00
Code Issues Projects Releases Packages Wiki Activity

a few improvements to code, comments, and tests

Browse source
This commit is contained in:
David Kennedy 2024-08-26 20:34:56 -04:00
parent 851e176f83
commit c2f71c984f
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
3 changed files with 17 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/registrar/admin.py
View file

@ -433,11 +433,9 @@ class MultiFieldSortableChangeList(admin.views.main.ChangeList):
def get_filters_params(self, params=None):
"""
Overrides the default behavior which gets filter_params, except
those in IGNORED_PARAMS. The override is to also include
portfolio in the overrides. This allows the portfolio filter
not to throw an error as a valid filter while not listing the
portfolio filter on the right side of the Change List view.
Add portfolio to ignored params to allow the portfolio filter while not
listing it as a filter option on the right side of Change List on the
portfolio list.
"""
params = params or self.params
lookup_params = params.copy() # a dictionary of the query string
@ -3018,7 +3016,7 @@ class PortfolioAdmin(ListHeaderAdmin):
if domain_count > 0:
# Construct the URL to the admin page, filtered by portfolio
url = reverse("admin:registrar_domain_changelist") + f"?portfolio={obj.id}"
label = "Domain" if domain_count == 1 else "Domains"
label = "Domain" if domain_count == 1 else "No domains"
# Create a clickable link with the domain count
return format_html('<a href="{}">{} {}</a>', url, domain_count, label)
return "No Domains"
@ -3033,7 +3031,7 @@ class PortfolioAdmin(ListHeaderAdmin):
url = reverse("admin:registrar_domainrequest_changelist") + f"?portfolio={obj.id}"
# Create a clickable link with the domain request count
return format_html('<a href="{}">{} Domain Requests</a>', url, domain_request_count)
return "No Domain Requests"
return "No domain requests"
domain_requests.short_description = "Domain requests" # type: ignore