diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index bd2239e69..3d7614620 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,3 +1,7 @@ # For more information on CODEOWNERS, see the documentation: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners -docs/* @dotgov \ No newline at end of file +# Default owners for all files +* @abroddrick + +# Owners for documentation +docs/* @cisagov/dotgov diff --git a/.github/ISSUE_TEMPLATE/developer-onboarding.md b/.github/ISSUE_TEMPLATE/developer-onboarding.md index b8f102685..74af9ef60 100644 --- a/.github/ISSUE_TEMPLATE/developer-onboarding.md +++ b/.github/ISSUE_TEMPLATE/developer-onboarding.md @@ -34,6 +34,8 @@ cf login -a api.fr.cloud.gov --sso **Note:** As mentioned in the [Login documentation](https://developers.login.gov/testing/), the sandbox Login account is different account from your regular, production Login account. If you have not created a Login account for the sandbox before, you will need to create a new account first. +- [ ] Optional- add yourself as a codeowner if desired. See the [Developer readme](https://github.com/cisagov/getgov/blob/main/docs/developer/README.md) for how to do this and what it does. + ### Steps for the onboarder - [ ] Add the onboardee to cloud.gov org (cisa-getgov-prototyping) - [ ] Setup a [developer specific space for the new developer](#setting-up-developer-sandbox) diff --git a/docs/developer/README.md b/docs/developer/README.md index a5e1d312e..d96fa7253 100644 --- a/docs/developer/README.md +++ b/docs/developer/README.md @@ -81,6 +81,22 @@ The endpoint /admin can be used to view and manage site content, including but n 5. In the browser, navigate to /admins. To verify that all is working correctly, under "domain applications" you should see fake domains with various fake statuses. +## Adding to CODEOWNERS (optional) + +The CODEOWNERS file sets the tagged individuals as default reviewers on any Pull Request that changes files that they are marked as owners of. + +1. Go to [.github\CODEOWNERS](../../.github/CODEOWNERS) +2. Following the [CODEOWNERS documentation](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners), add yourself as owner to files that you wish to be automatically requested as reviewer for. + + For example, if you wish to add yourself as a default reviewer for all pull requests, add your GitHub username to the same line as the `*` designator: + + ```diff + - * @abroddrick + + * @abroddrick @YourGitHubUser + ``` + +3. Create a pull request to finalize your changes + ## Viewing Logs If you run via `docker-compose up`, you'll see the logs in your terminal.