From bad8a8c98a75c1df161321c6a49d4b087d19e291 Mon Sep 17 00:00:00 2001
From: Rebecca Hsieh <rebecca.hsieh@truss.works>
Date: Sat, 4 Jan 2025 14:48:21 -0800
Subject: [PATCH] Fix padding on form and addin subtext for security email

---
 src/registrar/templates/domain_renewal.html        | 7 ++++---
 src/registrar/templates/includes/summary_item.html | 8 +++++---
 src/registrar/tests/test_views_domain.py           | 1 +
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/registrar/templates/domain_renewal.html b/src/registrar/templates/domain_renewal.html
index eda7a8bdd..4bf69dbca 100644
--- a/src/registrar/templates/domain_renewal.html
+++ b/src/registrar/templates/domain_renewal.html
@@ -26,6 +26,7 @@
   {{ block.super }}
   <div class="margin-top-4 tablet:grid-col-10">
     <h2 class="text-bold text-primary-dark domain-name-wrap">Confirm the following information for accuracy</h2>
+    <p> HELLO </p>
     <p>Review these details below. We <a href="https://get.gov/domains/requirements/#what-.gov-domain-registrants-must-do" class="usa-link">
       require</a> that you maintain accurate information for the domain.
       The details you provide will only be used to support eh administration of .gov and won't be made public.
@@ -55,9 +56,9 @@
 
     {% url 'domain-security-email' pk=domain.id as url %}
     {% if security_email is not None and security_email not in hidden_security_emails%}
-      {% include "includes/summary_item.html" with title='Security email' value=security_email edit_link=url editable=is_editable %}
+      {% include "includes/summary_item.html" with title='Security email' value=security_email custom_text_for_value_none='We strongly recommend that you provide a security email. This email will allow the  public to report observed or suspected security issues on your domain.' edit_link=url editable=is_editable %}
     {% else %}
-      {% include "includes/summary_item.html" with title='Security email' value='None provided' edit_link=url editable=is_editable %}
+      {% include "includes/summary_item.html" with title='Security email' value='None provided' custom_text_for_value_none='We strongly recommend that you provide a security email. This email will allow the  public to report observed or suspected security issues on your domain.' edit_link=url editable=is_editable %}
     {% endif %}
     {% url 'domain-users' pk=domain.id as url %}
     {% if portfolio %}
@@ -67,7 +68,7 @@
     {% endif %}
 
         
-    <div class="border-top-1px border-primary-dark padding-top-1 margin-bottom-2">
+    <div class="border-top-1px border-primary-dark padding-top-1 margin-top-3 margin-bottom-2">
 
       <fieldset class="usa-fieldset">
         <legend>
diff --git a/src/registrar/templates/includes/summary_item.html b/src/registrar/templates/includes/summary_item.html
index 15cc0f67f..facc8956a 100644
--- a/src/registrar/templates/includes/summary_item.html
+++ b/src/registrar/templates/includes/summary_item.html
@@ -128,11 +128,13 @@
         {% endif %}
       {% else %}
       <p class="margin-top-0 margin-bottom-0">
+        {% if custom_text_for_value_none %}
+          <p class="text-base-dark">{{ custom_text_for_value_none }}</p>
+        {% endif %}
         {% if value %}
           {{ value }}
-        {% elif custom_text_for_value_none %}
-          {{ custom_text_for_value_none }}
-        {% else %}
+        {% endif %}
+        {% if not value and not custom_text_for_value_none %}
           None
         {% endif %}
       </p>
diff --git a/src/registrar/tests/test_views_domain.py b/src/registrar/tests/test_views_domain.py
index 50b8f31f6..fa4351de1 100644
--- a/src/registrar/tests/test_views_domain.py
+++ b/src/registrar/tests/test_views_domain.py
@@ -631,6 +631,7 @@ class TestDomainDetailDomainRenewal(TestDomainOverview):
             "Check the box if you read and agree to the requirements for operating a .gov domain.",
         )
 
+
 class TestDomainManagers(TestDomainOverview):
     @classmethod
     def setUpClass(cls):