zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-12 22:18:25 +02:00
Code Issues Projects Releases Packages Wiki Activity

Check for api response codes when resetting values

Browse source
This commit is contained in:
zandercymatics 2024-08-12 09:11:14 -06:00
parent 0feb0a7ef8
commit b89ae53c84
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/registrar/assets/js/get-gov-admin.js
View file

@ -810,8 +810,8 @@ function initializeWidgetOnList(list, parentId) {
}else if (selectedText === "Non-Federal Agency" && organizationType.value === "federal") {
organizationType.value = "";
}
// There isn't a senior official associated with null records and non federal agencies
// There isn't a federal senior official associated with null records and non federal agencies
if (!selectedText || selectedText === "Non-Federal Agency") {
return;
}
@ -825,11 +825,16 @@ function initializeWidgetOnList(list, parentId) {
let seniorOfficialApi = document.querySelector("#senior_official_from_agency_json_url").value;
fetch(`${seniorOfficialApi}?agency_name=${selectedText}`)
.then(response => response.json())
.then(data => {
.then(response => {
const statusCode = response.status;
return response.json().then(data => ({ statusCode, data }));
})
.then(({ statusCode, data }) => {
if (data.error) {
// Clear the field if the SO doesn't exist
$seniorOfficial.val("").trigger("change");
// Clear the field if the SO doesn't exist.
if (statusCode === 404) {
$seniorOfficial.val("").trigger("change");
}
console.error("Error in AJAX call: " + data.error);
return;
}

2
src/registrar/models/portfolio.py
View file

@ -114,7 +114,7 @@ class Portfolio(TimeStampedModel):
def save(self, *args, **kwargs):
"""Save override for custom properties"""
# We can't have urbanization if the state isn't puerto rico
# The urbanization field is only intended for the state_territory puerto rico
if self.state_territory != self.StateTerritoryChoices.PUERTO_RICO and self.urbanization:
self.urbanization = None