zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-18 15:34:16 +02:00
Code Issues Projects Releases Packages Wiki Activity

wip variable name changes, and removing params from methods, and inheriting from global consts

Browse source
This commit is contained in:
David Kennedy 2024-12-11 12:02:44 -05:00
parent 7f0dc4bfca
commit b85bfd7244
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
1 changed files with 31 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

61
src/registrar/assets/src/js/getgov-admin/portfolio-form.js
View file

@ -14,13 +14,14 @@ function handlePortfolioFields(){
const seniorOfficialReadonly = seniorOfficialField.querySelector(".readonly"); const seniorOfficialReadonly = seniorOfficialField.querySelector(".readonly");
const $federalAgency = django.jQuery("#id_federal_agency"); const $federalAgency = django.jQuery("#id_federal_agency");
const federalAgencyField = document.querySelector(".field-federal_agency"); const federalAgencyField = document.querySelector(".field-federal_agency");
let organizationType = document.getElementById("id_organization_type"); const organizationTypeField = document.querySelector(".field-organization_type");
let readonlyOrganizationType = document.querySelector(".field-organization_type .readonly"); const organizationTypeReadonly = organizationTypeField.querySelector(".readonly");
let organizationName = document.querySelector(".field-organization_name"); const organizationTypeDropdown = document.getElementById("id_organization_type");
let federalType = document.querySelector(".field-federal_type"); const organizationNameField = document.querySelector(".field-organization_name");
let urbanization = document.querySelector(".field-urbanization"); const federalTypeField = document.querySelector(".field-federal_type");
let stateTerritory = document.getElementById("id_state_territory"); const urbanizationField = document.querySelector(".field-urbanization");
const stateTerritoryDropdown = document.getElementById("id_state_territory");
// consts for different urls
const seniorOfficialAddUrl = document.getElementById("senior-official-add-url").value; const seniorOfficialAddUrl = document.getElementById("senior-official-add-url").value;
function getFederalTypeFromAgency(agency) { function getFederalTypeFromAgency(agency) {
@ -65,26 +66,26 @@ function handlePortfolioFields(){
}); });
} }
function handleOrganizationTypeChange(organizationType, organizationNameContainer, federalType) { function handleOrganizationTypeChange() {
if (organizationType && organizationNameContainer) { if (organizationTypeDropdown && organizationNameField) {
let selectedValue = organizationType.value; let selectedValue = organizationTypeDropdown.value;
if (selectedValue === "federal") { if (selectedValue === "federal") {
hideElement(organizationNameContainer); hideElement(organizationNameField);
showElement(federalAgencyField); showElement(federalAgencyField);
if (federalType) { if (federalTypeField) {
showElement(federalType); showElement(federalTypeField);
} }
} else { } else {
showElement(organizationNameContainer); showElement(organizationNameField);
hideElement(federalAgencyField); hideElement(federalAgencyField);
if (federalType) { if (federalTypeField) {
hideElement(federalType); hideElement(federalTypeField);
} }
} }
} }
} }
function handleFederalAgencyChange(federalAgency, organizationType, readonlyOrganizationType, organizationNameContainer, federalType) { function handleFederalAgencyChange(federalAgency, organizationType, readonlyOrganizationType) {
if (!isPageLoading) { if (!isPageLoading) {
let selectedFederalAgency = federalAgency.find("option:selected").text(); let selectedFederalAgency = federalAgency.find("option:selected").text();
@ -112,7 +113,7 @@ function handlePortfolioFields(){
} }
} }
handleOrganizationTypeChange(organizationType, organizationNameContainer, federalType); handleOrganizationTypeChange();
// Determine if any changes are necessary to the display of portfolio type or federal type // Determine if any changes are necessary to the display of portfolio type or federal type
// based on changes to the Federal Agency // based on changes to the Federal Agency
@ -175,8 +176,8 @@ function handlePortfolioFields(){
} }
} }
function handleStateTerritoryChange(stateTerritory, urbanizationField) { function handleStateTerritoryChange() {
let selectedValue = stateTerritory.value; let selectedValue = stateTerritoryDropdown.value;
if (selectedValue === "PR") { if (selectedValue === "PR") {
showElement(urbanizationField) showElement(urbanizationField)
} else { } else {
@ -236,25 +237,25 @@ function handlePortfolioFields(){
} }
function initializePortfolioSettings() { function initializePortfolioSettings() {
if (urbanization && stateTerritory) { if (urbanizationField && stateTerritoryDropdown) {
handleStateTerritoryChange(stateTerritory, urbanization); handleStateTerritoryChange();
} }
handleOrganizationTypeChange(organizationType, organizationName, federalType); handleOrganizationTypeChange();
} }
function setEventListeners() { function setEventListeners() {
if ($federalAgency && (organizationType || readonlyOrganizationType)) { if ($federalAgency && (organizationTypeDropdown || organizationTypeReadonly)) {
$federalAgency.on("change", function() { $federalAgency.on("change", function() {
handleFederalAgencyChange($federalAgency, organizationType, readonlyOrganizationType, organizationName, federalType); handleFederalAgencyChange($federalAgency, organizationTypeDropdown, organizationTypeReadonly);
}); });
} }
if (urbanization && stateTerritory) { if (urbanizationField && stateTerritoryDropdown) {
stateTerritory.addEventListener("change", function() { stateTerritoryDropdown.addEventListener("change", function() {
handleStateTerritoryChange(stateTerritory, urbanization); handleStateTerritoryChange();
}); });
} }
organizationType.addEventListener("change", function() { organizationTypeDropdown.addEventListener("change", function() {
handleOrganizationTypeChange(organizationType, organizationName, federalType); handleOrganizationTypeChange();
}); });
} }