From e8d8a79d4f7dc84644d3350b73a22fdc5e7de241 Mon Sep 17 00:00:00 2001 From: Alysia Broddrick Date: Mon, 18 Dec 2023 20:27:32 -0800 Subject: [PATCH 1/5] add missing disclose in update --- src/registrar/models/domain.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/registrar/models/domain.py b/src/registrar/models/domain.py index 44cb45433..06cbc01e8 100644 --- a/src/registrar/models/domain.py +++ b/src/registrar/models/domain.py @@ -723,6 +723,7 @@ class Domain(TimeStampedModel, DomainHelper): fax=contact.fax, ) # type: ignore + updateContact.dislcose = self._disclose_fields(contact=contact) try: registry.send(updateContact, cleaned=True) except RegistryError as e: From 5856cc7230d1d7b5b02c20d5e49959d460f171fb Mon Sep 17 00:00:00 2001 From: Alysia Broddrick Date: Tue, 19 Dec 2023 14:01:55 -0800 Subject: [PATCH 2/5] added no type check --- src/registrar/models/domain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/registrar/models/domain.py b/src/registrar/models/domain.py index 06cbc01e8..dfc937504 100644 --- a/src/registrar/models/domain.py +++ b/src/registrar/models/domain.py @@ -723,7 +723,7 @@ class Domain(TimeStampedModel, DomainHelper): fax=contact.fax, ) # type: ignore - updateContact.dislcose = self._disclose_fields(contact=contact) + updateContact.dislcose = self._disclose_fields(contact=contact) # type: ignore try: registry.send(updateContact, cleaned=True) except RegistryError as e: From 961463a61c5818360650ad28491d56a699f21865 Mon Sep 17 00:00:00 2001 From: Alysia Broddrick Date: Thu, 21 Dec 2023 13:34:58 -0800 Subject: [PATCH 3/5] fixed typo --- src/registrar/models/domain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/registrar/models/domain.py b/src/registrar/models/domain.py index dfc937504..b1787049c 100644 --- a/src/registrar/models/domain.py +++ b/src/registrar/models/domain.py @@ -723,7 +723,7 @@ class Domain(TimeStampedModel, DomainHelper): fax=contact.fax, ) # type: ignore - updateContact.dislcose = self._disclose_fields(contact=contact) # type: ignore + updateContact.disclose = self._disclose_fields(contact=contact) # type: ignore try: registry.send(updateContact, cleaned=True) except RegistryError as e: From 80f034766851eb6da735319edaf5f730cca75b65 Mon Sep 17 00:00:00 2001 From: Alysia Broddrick Date: Thu, 21 Dec 2023 17:36:28 -0800 Subject: [PATCH 4/5] Updated tests --- src/registrar/models/domain.py | 1 + src/registrar/tests/common.py | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/registrar/models/domain.py b/src/registrar/models/domain.py index b1787049c..2b19d9453 100644 --- a/src/registrar/models/domain.py +++ b/src/registrar/models/domain.py @@ -721,6 +721,7 @@ class Domain(TimeStampedModel, DomainHelper): email=contact.email, voice=contact.voice, fax=contact.fax, + auth_info = epp.ContactAuthInfo(pw="2fooBAR123fooBaz"), ) # type: ignore updateContact.disclose = self._disclose_fields(contact=contact) # type: ignore diff --git a/src/registrar/tests/common.py b/src/registrar/tests/common.py index 5166e9c18..b3fb18ff8 100644 --- a/src/registrar/tests/common.py +++ b/src/registrar/tests/common.py @@ -1094,6 +1094,8 @@ class MockEppLib(TestCase): email=contact.email, voice=contact.voice, fax=contact.fax, + disclose=di, + auth_info=ai, ) def tearDown(self): From f9098b06cf53f266c545a14e7d0d480a3da11d45 Mon Sep 17 00:00:00 2001 From: Alysia Broddrick Date: Tue, 26 Dec 2023 19:09:05 -0800 Subject: [PATCH 5/5] ran linter --- src/registrar/models/domain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/registrar/models/domain.py b/src/registrar/models/domain.py index 2b19d9453..e06b43444 100644 --- a/src/registrar/models/domain.py +++ b/src/registrar/models/domain.py @@ -721,7 +721,7 @@ class Domain(TimeStampedModel, DomainHelper): email=contact.email, voice=contact.voice, fax=contact.fax, - auth_info = epp.ContactAuthInfo(pw="2fooBAR123fooBaz"), + auth_info=epp.ContactAuthInfo(pw="2fooBAR123fooBaz"), ) # type: ignore updateContact.disclose = self._disclose_fields(contact=contact) # type: ignore