From b7a5e0e763e72199a0d08f8761c40bdd63f1cded Mon Sep 17 00:00:00 2001
From: zandercymatics <141044360+zandercymatics@users.noreply.github.com>
Date: Thu, 28 Sep 2023 14:16:19 -0600
Subject: [PATCH] Linter mc linterton
---
src/registrar/models/domain.py | 3 +--
.../templates/django/admin/domain_change_form.html | 4 ++--
src/registrar/tests/test_admin.py | 9 ++++++---
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/registrar/models/domain.py b/src/registrar/models/domain.py
index 98b4120d5..b5f2814fc 100644
--- a/src/registrar/models/domain.py
+++ b/src/registrar/models/domain.py
@@ -653,8 +653,7 @@ class Domain(TimeStampedModel, DomainHelper):
"""This domain should be deleted from the registry
may raises RegistryError, should be caught or handled correctly by caller"""
request = commands.DeleteDomain(name=self.name)
- response = registry.send(request, cleaned=True)
- return response
+ registry.send(request, cleaned=True)
def __str__(self) -> str:
return self.name
diff --git a/src/registrar/templates/django/admin/domain_change_form.html b/src/registrar/templates/django/admin/domain_change_form.html
index ca44aa03c..1b8b90930 100644
--- a/src/registrar/templates/django/admin/domain_change_form.html
+++ b/src/registrar/templates/django/admin/domain_change_form.html
@@ -8,9 +8,9 @@
{% block field_sets %}
- {% if original.state == original.State.READY%}
+ {% if original.state == original.State.READY %}
- {% elif original.state == original.State.ON_HOLD%}
+ {% elif original.state == original.State.ON_HOLD %}
{% endif %}
diff --git a/src/registrar/tests/test_admin.py b/src/registrar/tests/test_admin.py
index c52af5628..31fa8fbcb 100644
--- a/src/registrar/tests/test_admin.py
+++ b/src/registrar/tests/test_admin.py
@@ -98,7 +98,8 @@ class TestDomainAdmin(MockEppLib):
domain = create_ready_domain()
# Put in client hold
domain.place_client_hold()
- self.client.login(username="staffuser", password="userpass")
+ p = "userpass"
+ self.client.login(username="staffuser", password=p)
# Ensure everything is displaying correctly
response = self.client.get(
@@ -137,7 +138,8 @@ class TestDomainAdmin(MockEppLib):
And `state` is not set to `DELETED`
"""
domain = create_ready_domain()
- self.client.login(username="staffuser", password="userpass")
+ p = "userpass"
+ self.client.login(username="staffuser", password=p)
# Ensure everything is displaying correctly
response = self.client.get(
@@ -180,7 +182,8 @@ class TestDomainAdmin(MockEppLib):
domain = create_ready_domain()
# Put in client hold
domain.place_client_hold()
- self.client.login(username="staffuser", password="userpass")
+ p = "userpass"
+ self.client.login(username="staffuser", password=p)
# Ensure everything is displaying correctly
response = self.client.get(