From b663ac7b713d9d78f6c31cdee64fb5acee78fc88 Mon Sep 17 00:00:00 2001 From: zandercymatics <141044360+zandercymatics@users.noreply.github.com> Date: Thu, 19 Oct 2023 09:28:11 -0600 Subject: [PATCH] Fix edge case on localhost --- src/epplibwrapper/client.py | 3 ++- src/epplibwrapper/socket.py | 4 ++++ src/epplibwrapper/tests/test_pool.py | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/epplibwrapper/client.py b/src/epplibwrapper/client.py index 4a65e63ea..77e152d0e 100644 --- a/src/epplibwrapper/client.py +++ b/src/epplibwrapper/client.py @@ -229,8 +229,9 @@ try: # Initialize epplib CLIENT = EPPLibWrapper() logger.info("registry client initialized") -except Exception: +except Exception as err: CLIENT = None # type: ignore logger.warning( "Unable to configure epplib. Registrar cannot contact registry.", exc_info=True ) + logger.warning(err) diff --git a/src/epplibwrapper/socket.py b/src/epplibwrapper/socket.py index 00cad80af..8329e36cf 100644 --- a/src/epplibwrapper/socket.py +++ b/src/epplibwrapper/socket.py @@ -60,6 +60,10 @@ class Socket: sleep((counter * 50) / 1000) # sleep 50 ms to 150 ms else: # don't try again return False + # Occurs when an invalid creds are passed in - such as on localhost + except OSError as err: + logger.error(err) + return False else: self.disconnect() diff --git a/src/epplibwrapper/tests/test_pool.py b/src/epplibwrapper/tests/test_pool.py index d7b4d4aad..f82d5ee6a 100644 --- a/src/epplibwrapper/tests/test_pool.py +++ b/src/epplibwrapper/tests/test_pool.py @@ -170,7 +170,7 @@ class TestConnectionPool(TestCase): patch.object(EPPConnectionPool, "_create_socket", self.fake_socket) ) stack.enter_context(patch.object(Socket, "connect", fake_client)) - + # Pool should be running self.assertEqual(registry.pool_status.connection_success, True) self.assertEqual(registry.pool_status.pool_running, True)