Edit to show error instead of caution

This commit is contained in:
Jon Roberts 2023-03-06 10:21:52 -05:00
parent 22eb49c004
commit b64f37efea
No known key found for this signature in database
GPG key ID: EED093582198B041
2 changed files with 9 additions and 18 deletions

View file

@ -1,8 +1,3 @@
{% comment %}
This only shows non-field errors at the top of form pages.
The individual field errors are not shown at the top of the
page, they are shown on each individual field.
{% endcomment %}
{% if form.errors %}
{% for error in form.non_field_errors %}
<div class="usa-alert usa-alert--error usa-alert--slim margin-bottom-2">
@ -11,4 +6,13 @@ page, they are shown on each individual field.
</div>
</div>
{% endfor %}
{% for field in form %}
{% for error in field.errors %}
<div class="usa-alert usa-alert--error usa-alert--slim margin-bottom-2">
<div class="usa-alert__body">
{{ error|escape }}
</div>
</div>
{% endfor %}
{% endfor %}
{% endif %}

View file

@ -321,19 +321,6 @@ class ApplicationWizard(LoginRequiredMixin, TemplateView):
# always save progress
self.save(forms)
else:
# unless there are errors
# no sec because this use of mark_safe does not introduce a cross-site
# scripting vulnerability because there is no untrusted content inside.
# It is only being used to pass a specific HTML entity into a template.
messages.warning(
request,
mark_safe( # nosec
"<b>We could not save all the fields.</b><br/> The highlighted "
+ "fields below <b>could not be saved</b> because they have "
+ "missing or invalid data. All other information on this page "
+ "has been saved."
),
)
context = self.get_context_data()
context["forms"] = forms
return render(request, self.template_name, context)