zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-31 23:16:36 +02:00
Code Issues Projects Releases Packages Wiki Activity

removed federal agency delete for OMB analysts

Browse source
This commit is contained in:
David Kennedy 2025-03-10 06:24:10 -04:00
parent 15c41cdce4
commit b5ab09db82
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
2 changed files with 1 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/registrar/admin.py
View file

@ -5025,15 +5025,6 @@ class FederalAgencyAdmin(ListHeaderAdmin, ImportExportRegistrarModelAdmin):
return obj.federal_type == BranchChoices.EXECUTIVE return obj.federal_type == BranchChoices.EXECUTIVE
return super().has_change_permission(request, obj) return super().has_change_permission(request, obj)
def has_delete_permission(self, request, obj=None):
"""Restrict delete permissions based on group membership and model attributes."""
if request.user.has_perm("registrar.full_access_permission"):
return True
if obj:
if request.user.groups.filter(name="omb_analysts_group").exists():
return obj.federal_type == BranchChoices.EXECUTIVE
return super().has_delete_permission(request, obj)
def get_readonly_fields(self, request, obj=None): def get_readonly_fields(self, request, obj=None):
"""Set the read-only state on form elements. """Set the read-only state on form elements.
We have 2 conditions that determine which fields are read-only: We have 2 conditions that determine which fields are read-only:

2
src/registrar/tests/test_admin.py
View file

@ -3821,7 +3821,7 @@ class TestFederalAgencyAdmin(TestCase):
self.assertNotContains(response, "id_is_fceb") self.assertNotContains(response, "id_is_fceb")
self.assertNotContains(response, "closelink") self.assertNotContains(response, "closelink")
self.assertContains(response, "Save") self.assertContains(response, "Save")
self.assertContains(response, "Delete") self.assertNotContains(response, "Delete")
@less_console_noise_decorator @less_console_noise_decorator
def test_superuser_change(self): def test_superuser_change(self):