zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-26 04:28:39 +02:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup + code simplification

Browse source
This commit is contained in:
zandercymatics 2025-02-12 10:31:01 -07:00
parent 0cdcedf955
commit b3a3dcad6d
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 27 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

67
src/registrar/assets/src/js/getgov-admin/analytics.js
View file

@ -41,7 +41,6 @@ function initAnalyticsExportButtons() {
}); });
}); });
} }
}; };
/** /**
@ -88,8 +87,8 @@ function createDiagonalPattern(backgroundColor, lineColor, rightToLeft=false, li
return context.createPattern(shape, "repeat"); return context.createPattern(shape, "repeat");
} }
function createComparativeColumnChart(canvasId, title, labelOne, labelTwo, chartInstances) { function createComparativeColumnChart(id, title, labelOne, labelTwo) {
var canvas = document.getElementById(canvasId); var canvas = document.getElementById(id);
if (!canvas) { if (!canvas) {
return return
} }
@ -140,57 +139,43 @@ function createComparativeColumnChart(canvasId, title, labelOne, labelTwo, chart
}, },
}, },
}; };
return new Chart(ctx, {
if (chartInstances.has(canvasId)) {
chartInstances.get(canvasId).destroy();
}
const chart = new Chart(ctx, {
type: "bar", type: "bar",
data: data, data: data,
options: options, options: options,
}); });
chartInstances.set(canvasId, chart);
} }
function initComparativeColumnCharts(chartInstances) {
// Create charts
const charts = [
{ id: "managed-domains-chart", title: "Managed domains" },
{ id: "unmanaged-domains-chart", title: "Unmanaged domains" },
{ id: "deleted-domains-chart", title: "Deleted domains" },
{ id: "ready-domains-chart", title: "Ready domains" },
{ id: "submitted-requests-chart", title: "Submitted requests" },
{ id: "all-requests-chart", title: "All requests" }
];
charts.forEach(chart => {
createComparativeColumnChart(
chart.id,
chart.title,
"Start Date",
"End Date",
chartInstances
);
});
// Add resize listener to each chart
window.addEventListener("resize", debounce(() => {
chartInstances.forEach((chart) => {
if (chart?.canvas) chart.resize();
});
}, 200));
};
/** An IIFE to initialize the analytics page /** An IIFE to initialize the analytics page
*/ */
export function initAnalyticsDashboard() { export function initAnalyticsDashboard() {
const chartInstances = new Map();
const analyticsPageContainer = document.querySelector('.analytics-dashboard .analytics-dashboard-charts'); const analyticsPageContainer = document.querySelector('.analytics-dashboard .analytics-dashboard-charts');
if (analyticsPageContainer) { if (analyticsPageContainer) {
document.addEventListener("DOMContentLoaded", function () { document.addEventListener("DOMContentLoaded", function () {
initAnalyticsExportButtons(); initAnalyticsExportButtons();
initComparativeColumnCharts(chartInstances);
// Create charts and store each instance of it
const chartInstances = new Map();
const charts = [
{ id: "managed-domains-chart", title: "Managed domains" },
{ id: "unmanaged-domains-chart", title: "Unmanaged domains" },
{ id: "deleted-domains-chart", title: "Deleted domains" },
{ id: "ready-domains-chart", title: "Ready domains" },
{ id: "submitted-requests-chart", title: "Submitted requests" },
{ id: "all-requests-chart", title: "All requests" }
];
charts.forEach(chart => {
if (chartInstances.has(chart.id)) chartInstances.get(chart.id).destroy();
let chart = createComparativeColumnChart(...chart, "Start Date", "End Date");
chartInstances.set(chart.id, chart);
});
// Add resize listener to each chart
window.addEventListener("resize", debounce(() => {
chartInstances.forEach((chart) => {
if (chart?.canvas) chart.resize();
});
}, 200));
}); });
} }
}; };

2
src/registrar/templates/admin/analytics_graph_table.html
View file

@ -23,4 +23,4 @@
{% endfor %} {% endfor %}
{% endwith %} {% endwith %}
</tbody> </tbody>
</table> </table>