zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-25 20:18:38 +02:00
Code Issues Projects Releases Packages Wiki Activity

simplified logic on check for existing permission in admin

Browse source
This commit is contained in:
David Kennedy 2025-01-02 16:56:54 -05:00
parent 2007daadbb
commit b39c143b9d
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/registrar/admin.py
View file

@ -1497,16 +1497,15 @@ class PortfolioInvitationAdmin(ListHeaderAdmin):
requested_email = obj.email
requestor = request.user
requested_user = User.objects.filter(email=requested_email).first()
permission_exists = UserPortfolioPermission.objects.filter(
user=requested_user, portfolio=portfolio
user__email=requested_email, portfolio=portfolio, user__email__isnull=False
).exists()
try:
if not requested_user or not permission_exists:
# if requested user does not exist or permission does not exist, send email
if not permission_exists:
# if permission does not exist for a user with requested_email, send email
send_portfolio_invitation_email(email=requested_email, requestor=requestor, portfolio=portfolio)
messages.success(request, f"{requested_email} has been invited.")
elif permission_exists:
else:
messages.warning(request, "User is already a member of this portfolio.")
except Exception as e:
# when exception is raised, handle and do not save the model