zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-14 05:29:43 +02:00
Code Issues Projects Releases Packages Wiki Activity

Avoid using an early return (consistency)

Browse source
This commit is contained in:
zandercymatics 2024-08-29 11:34:09 -06:00
parent b162ae8d7f
commit b27913f124
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
1 changed files with 14 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/registrar/management/commands/create_federal_portfolio.py
View file

@ -175,11 +175,10 @@ class Command(BaseCommand):
Updates all relevant domain request records. Updates all relevant domain request records.
""" """
domain_requests = DomainInformation.objects.filter(federal_agency=federal_agency) domain_requests = DomainInformation.objects.filter(federal_agency=federal_agency)
if len(domain_requests) < 1: if not domain_requests.exists():
message = "Portfolios not added to domain requests: no valid records found" message = "Portfolios not added to domain requests: no valid records found"
TerminalHelper.colorful_logger(logger.info, TerminalColors.YELLOW, message) TerminalHelper.colorful_logger(logger.info, TerminalColors.YELLOW, message)
return else:
for domain_request in domain_requests: for domain_request in domain_requests:
domain_request.portfolio = portfolio domain_request.portfolio = portfolio
@ -193,12 +192,11 @@ class Command(BaseCommand):
Updates all relevant domain information records. Updates all relevant domain information records.
""" """
domain_infos = DomainInformation.objects.filter(federal_agency=federal_agency) domain_infos = DomainInformation.objects.filter(federal_agency=federal_agency)
if not domain_infos.exists():
if len(domain_infos) < 1:
message = "Portfolios not added to domains: no valid records found" message = "Portfolios not added to domains: no valid records found"
TerminalHelper.colorful_logger(logger.info, TerminalColors.YELLOW, message) TerminalHelper.colorful_logger(logger.info, TerminalColors.YELLOW, message)
return return
else:
for domain_info in domain_infos: for domain_info in domain_infos:
domain_info.portfolio = portfolio domain_info.portfolio = portfolio