zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-05 01:11:55 +02:00
Code Issues Projects Releases Packages Wiki Activity

Avoid using an early return (consistency)

Browse source
This commit is contained in:
zandercymatics 2024-08-29 11:34:09 -06:00
parent b162ae8d7f
commit b27913f124
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
1 changed files with 14 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/registrar/management/commands/create_federal_portfolio.py
View file

@ -175,17 +175,16 @@ class Command(BaseCommand):
Updates all relevant domain request records.
"""
domain_requests = DomainInformation.objects.filter(federal_agency=federal_agency)
if len(domain_requests) < 1:
if not domain_requests.exists():
message = "Portfolios not added to domain requests: no valid records found"
TerminalHelper.colorful_logger(logger.info, TerminalColors.YELLOW, message)
return
else:
for domain_request in domain_requests:
domain_request.portfolio = portfolio
for domain_request in domain_requests:
domain_request.portfolio = portfolio
DomainRequest.objects.bulk_update(domain_requests, ["portfolio"])
message = f"Added portfolio '{portfolio}' to {len(domain_requests)} domain requests"
TerminalHelper.colorful_logger(logger.info, TerminalColors.OKGREEN, message)
DomainRequest.objects.bulk_update(domain_requests, ["portfolio"])
message = f"Added portfolio '{portfolio}' to {len(domain_requests)} domain requests"
TerminalHelper.colorful_logger(logger.info, TerminalColors.OKGREEN, message)
def handle_portfolio_domains(self, portfolio: Portfolio, federal_agency: FederalAgency):
"""
@ -193,15 +192,14 @@ class Command(BaseCommand):
Updates all relevant domain information records.
"""
domain_infos = DomainInformation.objects.filter(federal_agency=federal_agency)
if len(domain_infos) < 1:
if not domain_infos.exists():
message = "Portfolios not added to domains: no valid records found"
TerminalHelper.colorful_logger(logger.info, TerminalColors.YELLOW, message)
return
else:
for domain_info in domain_infos:
domain_info.portfolio = portfolio
for domain_info in domain_infos:
domain_info.portfolio = portfolio
DomainInformation.objects.bulk_update(domain_infos, ["portfolio"])
message = f"Added portfolio '{portfolio}' to {len(domain_infos)} domains"
TerminalHelper.colorful_logger(logger.info, TerminalColors.OKGREEN, message)
DomainInformation.objects.bulk_update(domain_infos, ["portfolio"])
message = f"Added portfolio '{portfolio}' to {len(domain_infos)} domains"
TerminalHelper.colorful_logger(logger.info, TerminalColors.OKGREEN, message)