From 7ace7fa27c2a1803987bb51fd14101e66ab11806 Mon Sep 17 00:00:00 2001 From: David Kennedy Date: Thu, 5 Oct 2023 08:42:39 -0400 Subject: [PATCH 1/2] app-wide change to input display in forms if field is required, had an initial value, but user removed the value before submitting form' --- src/registrar/templatetags/field_helpers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/registrar/templatetags/field_helpers.py b/src/registrar/templatetags/field_helpers.py index c62cb10aa..bc296753e 100644 --- a/src/registrar/templatetags/field_helpers.py +++ b/src/registrar/templatetags/field_helpers.py @@ -149,7 +149,7 @@ def input_with_errors(context, field=None): # noqa: C901 # see Widget.get_context() on # https://docs.djangoproject.com/en/4.1/ref/forms/widgets widget = field.field.widget.get_context( - field.html_name, field.value() or field.initial, field.build_widget_attrs(attrs) + field.html_name, field.value(), field.build_widget_attrs(attrs) ) # -> {"widget": {"name": ...}} context["widget"] = widget["widget"] From 7bd6e7f5939308324d07278c7c6552a73efea009 Mon Sep 17 00:00:00 2001 From: David Kennedy Date: Thu, 5 Oct 2023 16:11:56 -0400 Subject: [PATCH 2/2] logic in domain_sidebar which determines display of DS Data and Key Data --- src/registrar/templates/domain_sidebar.html | 2 +- src/registrar/templatetags/url_helpers.py | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/registrar/templates/domain_sidebar.html b/src/registrar/templates/domain_sidebar.html index d31ce613a..aff9f5dab 100644 --- a/src/registrar/templates/domain_sidebar.html +++ b/src/registrar/templates/domain_sidebar.html @@ -34,7 +34,7 @@ > DNSSEC - {% if domain.dnssec_enabled %} + {% if domain.dnssecdata is not None or request.path|startswith:url and request.path|endswith:'data' %}